Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 2123003002: 🎥 Fix java_cpp_template srcjars having .d files and extra path component (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 5 months ago
Reviewers:
Peter Wen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix java_cpp_template srcjars having .d files and extra path component Directories within srcjars are supposed to reflect java package names. The extra path component was making Android Studio unhappy. BUG=620034 Committed: https://crrev.com/a6e90c933afa77aae92cab39edc89db34cd7455e Cr-Commit-Position: refs/heads/master@{#403897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -35 lines) Patch
M build/config/android/rules.gni View 2 chunks +19 lines, -35 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123003002/1
4 years, 5 months ago (2016-07-05 18:31:44 UTC) #2
agrieve
On 2016/07/05 18:31:44, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 5 months ago (2016-07-05 18:37:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-05 19:37:20 UTC) #7
Peter Wen
lgtm Stamp stamp stamp. 🙋
4 years, 5 months ago (2016-07-05 21:15:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123003002/1
4 years, 5 months ago (2016-07-06 13:38:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 13:42:13 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 13:43:58 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6e90c933afa77aae92cab39edc89db34cd7455e
Cr-Commit-Position: refs/heads/master@{#403897}

Powered by Google App Engine
This is Rietveld 408576698