🎥 Fix java_cpp_template srcjars having .d files and extra path component

build/config/android/rules.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/android/internal_rules.gni")
 import("//build/toolchain/toolchain.gni")
 
 assert(is_android)
 
@@ skipping 347 matching lines @@
   #       "android/java/templates/native_foo_header.h",
   #     ]
   #
   #     package_name = "org/chromium/base/library_loader"
   #     include_path = "android/java/templates"
   #   }
   template("java_cpp_template") {
     set_sources_assignment_filter([])
     forward_variables_from(invoker, [ "testonly" ])
 
-    assert(defined(invoker.sources))
-    package_name = invoker.package_name + ""
-
+    _include_path = "//"
     if (defined(invoker.include_path)) {
-      include_path = invoker.include_path + ""
-    } else {
-      include_path = "//"
+      _include_path = invoker.include_path
     }
 
-    apply_gcc_target_name = "${target_name}__apply_gcc"
-    zip_srcjar_target_name = "${target_name}__zip_srcjar"
-    final_target_name = target_name
+    _apply_gcc_target_name = "${target_name}__apply_gcc"
+    _base_gen_dir = "${target_gen_dir}/${target_name}/java_cpp_template"
 
-    action_foreach(apply_gcc_target_name) {
+    action_foreach(_apply_gcc_target_name) {
       forward_variables_from(invoker,
                              [
                                "deps",
                                "public_deps",
                                "data_deps",
                              ])
-      visibility = [ ":$zip_srcjar_target_name" ]
       script = "//build/android/gyp/gcc_preprocess.py"
       if (defined(invoker.inputs)) {
         inputs = invoker.inputs + []
       }
-      depfile = "${target_gen_dir}/${target_name}_{{source_name_part}}.d"
+      depfile =
+          "${target_gen_dir}/${invoker.target_name}_{{source_name_part}}.d"
 
       sources = invoker.sources
 
-      gen_dir =
-          "${target_gen_dir}/${target_name}/java_cpp_template/${package_name}"
-      gcc_template_output_pattern = "${gen_dir}/{{source_name_part}}.java"
-
       outputs = [
         depfile,
-        gcc_template_output_pattern,
+        "$_base_gen_dir/${invoker.package_name}/{{source_name_part}}.java",
       ]
 
       args = [
         "--depfile",
         rebase_path(depfile, root_build_dir),
         "--include-path",
-        rebase_path(include_path, root_build_dir),
+        rebase_path(_include_path, root_build_dir),
         "--output",
-        rebase_path(gen_dir, root_build_dir) + "/{{source_name_part}}.java",
+        rebase_path(outputs[1], root_build_dir),
         "--template={{source}}",
       ]
 
       if (defined(invoker.defines)) {
         foreach(def, invoker.defines) {
           args += [
             "--defines",
             def,
           ]
         }
       }
     }
 
-    apply_gcc_outputs = get_target_outputs(":$apply_gcc_target_name")
-    base_gen_dir = get_label_info(":$apply_gcc_target_name", "target_gen_dir")
+    # Filter out .d files.
+    set_sources_assignment_filter([ "*.d" ])
+    sources = get_target_outputs(":$_apply_gcc_target_name")
 
-    srcjar_path = "${target_gen_dir}/${target_name}.srcjar"
-    zip(zip_srcjar_target_name) {
-      visibility = [ ":$final_target_name" ]
-      inputs = apply_gcc_outputs
-      output = srcjar_path
-      base_dir = base_gen_dir
+    zip(target_name) {
+      forward_variables_from(invoker, [ "visibility" ])
+      inputs = sources
+      output = "${target_gen_dir}/${target_name}.srcjar"
+      base_dir = _base_gen_dir
       deps = [
-        ":$apply_gcc_target_name",
-      ]
-    }
-
-    group(final_target_name) {
-      forward_variables_from(invoker, [ "visibility" ])
-      public_deps = [
-        ":$zip_srcjar_target_name",
+        ":$_apply_gcc_target_name",
       ]
     }
   }
 
   # Declare a target for generating Java classes from C++ enums.
   #
   # This target generates Java files from C++ enums using a script.
   #
   # This target will create a single .srcjar. Adding this target to an
   # android_library target's srcjar_deps will make the generated java files be
@@ skipping 2105 matching lines @@
     android_library(target_name) {
       chromium_code = false
       java_files = []
       srcjar_deps = [ ":${_template_name}__protoc_java" ]
       deps = [
         "//third_party/android_protobuf:protobuf_nano_javalib",
       ]
     }
   }
 }