Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4722)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java

Issue 2122993003: Remove unused Interests code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Forgot unit test target. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java
deleted file mode 100644
index 691b8343d28cbe96d81fd7af7126d43fbadf6865..0000000000000000000000000000000000000000
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java
+++ /dev/null
@@ -1,150 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.ntp.interests;
-
-import android.content.Context;
-import android.view.View;
-
-import org.chromium.base.ApiCompatibilityUtils;
-import org.chromium.base.metrics.RecordHistogram;
-import org.chromium.base.metrics.RecordUserAction;
-import org.chromium.chrome.R;
-import org.chromium.chrome.browser.NativePage;
-import org.chromium.chrome.browser.UrlConstants;
-import org.chromium.chrome.browser.ntp.NewTabPageUma;
-import org.chromium.chrome.browser.ntp.NtpColorUtils;
-import org.chromium.chrome.browser.ntp.interests.InterestsService.GetInterestsCallback;
-import org.chromium.chrome.browser.ntp.interests.InterestsService.Interest;
-import org.chromium.chrome.browser.profiles.Profile;
-import org.chromium.chrome.browser.tab.Tab;
-import org.chromium.ui.widget.Toast;
-
-import java.util.Arrays;
-import java.util.List;
-
-/**
- * Displays a list of topics that we think the user is interested in. When an interest is clicked
- * the user is redirected to a search for that subject.
- */
-public class InterestsPage implements NativePage {
-
- private static final String TAG = "InterestsPage";
-
- private final InterestsView mPageView;
- private final String mTitle;
- private final int mBackgroundColor;
- private final int mThemeColor;
-
- private boolean mClicked;
-
- /**
- * Creates an InterestsPage.
- *
- * @param context The view context for showing the page.
- * @param tab The tab from which interests page is loaded.
- * @param profile The profile from which to load interests.
- */
- public InterestsPage(final Context context, Tab tab, Profile profile) {
- mTitle = context.getResources().getString(R.string.ntp_interests);
- mBackgroundColor = NtpColorUtils.getBackgroundColorResource(context.getResources(), false);
- mThemeColor = ApiCompatibilityUtils.getColor(
- context.getResources(), R.color.default_primary_color);
- mPageView = (InterestsView) View.inflate(context, R.layout.interests_page, null);
-
- new InterestsService(profile).getInterests(
- new GetInterestsCallback() {
- @Override
- public void onInterestsAvailable(Interest[] interests) {
- boolean gotInterests = interests != null;
- RecordHistogram.recordBooleanHistogram(
- "NewTabPage.Interests.InterestsFetchSuccess", gotInterests);
- if (!gotInterests) {
- showToastOnFailure();
- return;
- }
- List<Interest> interestList = Arrays.asList(interests);
- // We use sparse histograms here like in NewTabPage.Snippets.NumArticles,
- // NewTabPage.NumberOfTiles etc as this will measure a small number (< 30)
- // which is expected to be constant for a user and prefer exact counts
- // without defining artificial bucket boundaries.
- RecordHistogram.recordSparseSlowlyHistogram(
- "NewTabPage.Interests.NumInterests", interestList.size());
- if (interestList.size() == 0) {
- showToastOnFailure();
- return;
- }
- mPageView.setInterests(interestList);
- }
-
- private void showToastOnFailure() {
- Toast.makeText(context, R.string.ntp_no_interests_toast, Toast.LENGTH_SHORT)
- .show();
- }
- });
- }
-
- public void setListener(final InterestsClickListener listener) {
- mPageView.setListener(new InterestsClickListener() {
- public void onInterestClicked(String interest) {
- mClicked = true;
- NewTabPageUma.recordAction(NewTabPageUma.ACTION_CLICKED_INTEREST);
- RecordUserAction.record("MobileNTP.Interests.Click");
- listener.onInterestClicked(interest);
- }
- });
- }
-
- /**
- * Interface to be notified when the user clicks on an interest.
- **/
- public interface InterestsClickListener {
- /**
- * Called when an interest is selected.
- *
- * @param name The name of the selected interest.
- */
- void onInterestClicked(String name);
- }
-
- @Override
- public String getTitle() {
- return mTitle;
- }
-
- @Override
- public int getBackgroundColor() {
- return mBackgroundColor;
- }
-
- @Override
- public int getThemeColor() {
- return mThemeColor;
- }
- @Override
- public View getView() {
- return mPageView;
- }
-
-
- @Override
- public void destroy() {
- if (mClicked) return;
- RecordUserAction.record("MobileNTP.Interests.Dismissed");
- }
-
- @Override
- public String getHost() {
- return UrlConstants.INTERESTS_HOST;
- }
-
- @Override
- public String getUrl() {
- return UrlConstants.INTERESTS_URL;
- }
-
- @Override
- public void updateForUrl(String url) {
- }
-}

Powered by Google App Engine
This is Rietveld 408576698