Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2122943002: Abort if we ever allocate a non-0-sized packed array (Closed)

Created:
4 years, 5 months ago by Toon Verwaest
Modified:
4 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Abort if we ever allocate a non-0-sized packed array BUG=chromium:621147 Committed: https://crrev.com/c2eb07505cc055bd30ff94f72bd0bf84db085b87 Cr-Commit-Position: refs/heads/master@{#37535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -16 lines) Patch
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +25 lines, -10 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
ptal
4 years, 5 months ago (2016-07-05 15:07:12 UTC) #2
Jakob Kummerow
lgtm
4 years, 5 months ago (2016-07-05 15:21:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122943002/1
4 years, 5 months ago (2016-07-05 15:22:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 15:49:58 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 15:50:00 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 15:52:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2eb07505cc055bd30ff94f72bd0bf84db085b87
Cr-Commit-Position: refs/heads/master@{#37535}

Powered by Google App Engine
This is Rietveld 408576698