src/code-stub-assembler.cc - Issue 2122943002: Abort if we ever allocate a non-0-sized packed array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-stub-assembler.cc

Issue 2122943002: Abort if we ever allocate a non-0-sized packed array (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/code-stub-assembler.cc

diff --git a/src/code-stub-assembler.cc b/src/code-stub-assembler.cc

index 616f628c44966e6f851c89914eb8b912cbc85cef..9371fdacab37d732de8f93ecb082d8c08e931ecb 100644

--- a/src/code-stub-assembler.cc

+++ b/src/code-stub-assembler.cc

@@ -834,8 +834,7 @@ Node* CodeStubAssembler::AllocateJSArray(ElementsKind kind, Node* array_map,

Heap* heap = isolate()->heap();

Node* array = Allocate(total_size);

StoreMapNoWriteBarrier(array, array_map);

- Node* empty_properties =

- HeapConstant(Handle<HeapObject>(heap->empty_fixed_array()));

+ Node* empty_properties = LoadRoot(Heap::kEmptyFixedArrayRootIndex);

StoreObjectFieldNoWriteBarrier(array, JSArray::kPropertiesOffset,

empty_properties);

StoreObjectFieldNoWriteBarrier(

« no previous file with comments | « src/bailout-reason.h ('k') | src/code-stubs.cc » ('j') | no next file with comments »