[MD History] Fix issues caused by refactor.

[MD History] Fix issues caused by refactor.

This CL fixes a number of issues that were introduced by
https://codereview.chromium.org/2084843002/.

- Search was broken because queryingDisabled was initialized with a
  Boolean instead of false. Closure didn't catch it because having
  getters/setters in an object causes it to give up.
- Synced tabs labels were not showing because the search term was not
  plumbed through correctly. A test has been added to ensure the text
  is rendered.
- The grouped toolbar had no query begin/end time data. The
  queryResult has been moved into history-app so that the toolbar can
  access it.

BUG=619799
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9b14871b23eeee6453d823cbb0a282df9a39ced5
Cr-Commit-Position: refs/heads/master@{#403757}

[calamity, 2016-07-05 06:08:35]

Description was changed from

==========
[MD History] Fix issues caused by refactor.

This CL fixes a number of issues that were introduced by
https://codereview.chromium.org/2084843002/.

- Search was broken because queryingDisabled was initialized with a
  Boolean instead of false. Closure didn't catch it because having
  getters/setters in an object causes it to give up.
- Synced tabs labels were not showing because the search term was not
  plumbed through correctly. A test has been added to ensure the text
  is rendered.
- The grouped toolbar had no query begin/end time data.

BUG=619799
==========

to

==========
[MD History] Fix issues caused by refactor.

This CL fixes a number of issues that were introduced by
https://codereview.chromium.org/2084843002/.

- Search was broken because queryingDisabled was initialized with a
  Boolean instead of false. Closure didn't catch it because having
  getters/setters in an object causes it to give up.
- Synced tabs labels were not showing because the search term was not
  plumbed through correctly. A test has been added to ensure the text
  is rendered.
- The grouped toolbar had no query begin/end time data.

BUG=619799
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-07-05 06:30:45]

Description was changed from

==========
[MD History] Fix issues caused by refactor.

This CL fixes a number of issues that were introduced by
https://codereview.chromium.org/2084843002/.

- Search was broken because queryingDisabled was initialized with a
  Boolean instead of false. Closure didn't catch it because having
  getters/setters in an object causes it to give up.
- Synced tabs labels were not showing because the search term was not
  plumbed through correctly. A test has been added to ensure the text
  is rendered.
- The grouped toolbar had no query begin/end time data.

BUG=619799
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Fix issues caused by refactor.

This CL fixes a number of issues that were introduced by
https://codereview.chromium.org/2084843002/.

- Search was broken because queryingDisabled was initialized with a
  Boolean instead of false. Closure didn't catch it because having
  getters/setters in an object causes it to give up.
- Synced tabs labels were not showing because the search term was not
  plumbed through correctly. A test has been added to ensure the text
  is rendered.
- The grouped toolbar had no query begin/end time data. The
  queryResult has been moved into history-app so that the toolbar can
  access it.

BUG=619799
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-07-05 06:45:07]

Patchset #1 (id:1) has been deleted

[calamity, 2016-07-05 06:45:20]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-07-05 07:22:31]

lgtm w/ nit

https://codereview.chromium.org/2122823002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_synced_tabs_test.js (right):

https://codereview.chromium.org/2122823002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_synced_tabs_test.js:180:
.textContent.trim());
One more thing you might want to test: We should probably check that the title
renders even when there isn't a search. If the (null) search term doesn't plumb
through correctly this can still cause problems.

[calamity, 2016-07-05 08:10:20]

https://codereview.chromium.org/2122823002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_synced_tabs_test.js (right):

https://codereview.chromium.org/2122823002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_synced_tabs_test.js:180:
.textContent.trim());
On 2016/07/05 07:22:31, tsergeant wrote:
> One more thing you might want to test: We should probably check that the title
> renders even when there isn't a search. If the (null) search term doesn't
plumb
> through correctly this can still cause problems.

Done.

[calamity, 2016-07-05 08:10:24]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-07-05 08:10:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2122823002/#ps40001
(title: "fix nit")

[commit-bot: I haz the power, 2016-07-05 08:10:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 09:13:16]

Description was changed from

==========
[MD History] Fix issues caused by refactor.

This CL fixes a number of issues that were introduced by
https://codereview.chromium.org/2084843002/.

- Search was broken because queryingDisabled was initialized with a
  Boolean instead of false. Closure didn't catch it because having
  getters/setters in an object causes it to give up.
- Synced tabs labels were not showing because the search term was not
  plumbed through correctly. A test has been added to ensure the text
  is rendered.
- The grouped toolbar had no query begin/end time data. The
  queryResult has been moved into history-app so that the toolbar can
  access it.

BUG=619799
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Fix issues caused by refactor.

This CL fixes a number of issues that were introduced by
https://codereview.chromium.org/2084843002/.

- Search was broken because queryingDisabled was initialized with a
  Boolean instead of false. Closure didn't catch it because having
  getters/setters in an object causes it to give up.
- Synced tabs labels were not showing because the search term was not
  plumbed through correctly. A test has been added to ensure the text
  is rendered.
- The grouped toolbar had no query begin/end time data. The
  queryResult has been moved into history-app so that the toolbar can
  access it.

BUG=619799
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-05 09:13:17]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-07-05 09:13:25]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-05 09:14:38]

Description was changed from

==========
[MD History] Fix issues caused by refactor.

This CL fixes a number of issues that were introduced by
https://codereview.chromium.org/2084843002/.

- Search was broken because queryingDisabled was initialized with a
  Boolean instead of false. Closure didn't catch it because having
  getters/setters in an object causes it to give up.
- Synced tabs labels were not showing because the search term was not
  plumbed through correctly. A test has been added to ensure the text
  is rendered.
- The grouped toolbar had no query begin/end time data. The
  queryResult has been moved into history-app so that the toolbar can
  access it.

BUG=619799
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Fix issues caused by refactor.

This CL fixes a number of issues that were introduced by
https://codereview.chromium.org/2084843002/.

- Search was broken because queryingDisabled was initialized with a
  Boolean instead of false. Closure didn't catch it because having
  getters/setters in an object causes it to give up.
- Synced tabs labels were not showing because the search term was not
  plumbed through correctly. A test has been added to ensure the text
  is rendered.
- The grouped toolbar had no query begin/end time data. The
  queryResult has been moved into history-app so that the toolbar can
  access it.

BUG=619799
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9b14871b23eeee6453d823cbb0a282df9a39ced5
Cr-Commit-Position: refs/heads/master@{#403757}
==========

[commit-bot: I haz the power, 2016-07-05 09:14:39]

Patchset 2 (id:??) landed as
https://crrev.com/9b14871b23eeee6453d823cbb0a282df9a39ced5
Cr-Commit-Position: refs/heads/master@{#403757}