|
|
Created:
4 years, 5 months ago by calamity Modified:
4 years, 5 months ago Reviewers:
tsergeant CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_shit Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD History] Add 2-way binding to query state.
This CL fixes an issue where the query state was not correctly bound to
the list container. This caused the loading spinner and message to break.
BUG=619799
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/279f2470f520e8d7dbdd90066d06eac1a25f647d
Cr-Commit-Position: refs/heads/master@{#405068}
Patch Set 1 : test #Patch Set 2 : rebase #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== [MD History] Add 2-way binding to query state. This CL fixes an issue where the query state was not correctly bound to the list container. BUG=619799 ========== to ========== [MD History] Add 2-way binding to query state. This CL fixes an issue where the query state was not correctly bound to the list container. BUG=619799 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== [MD History] Add 2-way binding to query state. This CL fixes an issue where the query state was not correctly bound to the list container. BUG=619799 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD History] Add 2-way binding to query state. This CL fixes an issue where the query state was not correctly bound to the list container. This caused the loading spinner and message to break. BUG=619799 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
calamity@chromium.org changed reviewers: + tsergeant@chromium.org
{{lgtm}}
On 2016/07/08 02:24:45, tsergeant wrote: > {{lgtm}} (and woo-hoo, increasing test coverage)
The CQ bit was checked by calamity@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for chrome/test/data/webui/md_history/history_toolbar_test.js: While running git apply --index -3 -p1; error: patch failed: chrome/test/data/webui/md_history/history_toolbar_test.js:45 Falling back to three-way merge... Applied patch to 'chrome/test/data/webui/md_history/history_toolbar_test.js' with conflicts. U chrome/test/data/webui/md_history/history_toolbar_test.js Patch: chrome/test/data/webui/md_history/history_toolbar_test.js Index: chrome/test/data/webui/md_history/history_toolbar_test.js diff --git a/chrome/test/data/webui/md_history/history_toolbar_test.js b/chrome/test/data/webui/md_history/history_toolbar_test.js index 86f6f02b4b08ee39cda66844f1a1a2f62825b14a..efd43ebc56051a229b1299df7b64fc4895cfc5a4 100644 --- a/chrome/test/data/webui/md_history/history_toolbar_test.js +++ b/chrome/test/data/webui/md_history/history_toolbar_test.js @@ -45,13 +45,25 @@ cr.define('md_history.history_toolbar_test', function() { test('search term gathered correctly from toolbar', function(done) { app.queryState_.queryingDisabled = false; registerMessageCallback('queryHistory', this, function (info) { - assertEquals(info[0], 'Test'); + assertEquals('Test', info[0]); done(); }); toolbar.$$('cr-toolbar').fire('search-changed', 'Test'); }); + test('spinner is active on search' , function(done) { + app.queryState_.queryingDisabled = false; + registerMessageCallback('queryHistory', this, function (info) { + assertTrue(toolbar.spinnerActive); + app.historyResult(createHistoryInfo(), TEST_HISTORY_RESULTS); + assertFalse(toolbar.spinnerActive); + done(); + }); + + toolbar.$$('cr-toolbar').fire('search-changed', 'Test2'); + }); + teardown(function() { element.historyData_ = []; element.searchedTerm = '';
The CQ bit was unchecked by commit-bot@chromium.org
CQ bit was unchecked.
The CQ bit was checked by calamity@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tsergeant@chromium.org Link to the patchset: https://codereview.chromium.org/2126173002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [MD History] Add 2-way binding to query state. This CL fixes an issue where the query state was not correctly bound to the list container. This caused the loading spinner and message to break. BUG=619799 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD History] Add 2-way binding to query state. This CL fixes an issue where the query state was not correctly bound to the list container. This caused the loading spinner and message to break. BUG=619799 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [MD History] Add 2-way binding to query state. This CL fixes an issue where the query state was not correctly bound to the list container. This caused the loading spinner and message to break. BUG=619799 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD History] Add 2-way binding to query state. This CL fixes an issue where the query state was not correctly bound to the list container. This caused the loading spinner and message to break. BUG=619799 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/279f2470f520e8d7dbdd90066d06eac1a25f647d Cr-Commit-Position: refs/heads/master@{#405068} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/279f2470f520e8d7dbdd90066d06eac1a25f647d Cr-Commit-Position: refs/heads/master@{#405068} |