Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2126173002: [MD History] Add 2-way binding to query state. (Closed)

Created:
4 years, 5 months ago by calamity
Modified:
4 years, 5 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_shit
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Add 2-way binding to query state. This CL fixes an issue where the query state was not correctly bound to the list container. This caused the loading spinner and message to break. BUG=619799 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/279f2470f520e8d7dbdd90066d06eac1a25f647d Cr-Commit-Position: refs/heads/master@{#405068}

Patch Set 1 : test #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/resources/md_history/app.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/md_history/history_toolbar_test.js View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
calamity
4 years, 5 months ago (2016-07-08 01:45:02 UTC) #5
tsergeant
{{lgtm}}
4 years, 5 months ago (2016-07-08 02:24:45 UTC) #6
tsergeant
On 2016/07/08 02:24:45, tsergeant wrote: > {{lgtm}} (and woo-hoo, increasing test coverage)
4 years, 5 months ago (2016-07-08 02:25:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126173002/20001
4 years, 5 months ago (2016-07-08 05:47:00 UTC) #9
commit-bot: I haz the power
Failed to apply patch for chrome/test/data/webui/md_history/history_toolbar_test.js: While running git apply --index -3 -p1; error: patch ...
4 years, 5 months ago (2016-07-08 14:22:35 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 14:22:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126173002/40001
4 years, 5 months ago (2016-07-13 05:42:32 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-13 07:27:10 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 07:28:47 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/279f2470f520e8d7dbdd90066d06eac1a25f647d
Cr-Commit-Position: refs/heads/master@{#405068}

Powered by Google App Engine
This is Rietveld 408576698