Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2122813002: Revert of Use metadata when launching WebAPKs. (Closed)

Created:
4 years, 5 months ago by Kunihiko Sakamoto
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use metadata when launching WebAPKs. (patchset #11 id:480001 of https://codereview.chromium.org/2071213005/ ) Reason for revert: Broke chrome_public_test_apk in Android Tests (dbg). https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35147 Original issue's description: > Use metadata when launching WebAPKs. > > WebAPKs use WebappDataStorage to store the metadata too. > Some changes in the web app manifest, like themeColor, > orientation etc. don't request re-minting a WebAPK, > but will update the metadata in the SharedPreference > (WebappDataStorage). The metadata will be retrieved > and used for launching a WebAPK. > > Registering a WebAPK will be in a following up CL. > > BUG=624834 > > Committed: https://crrev.com/a6fe748fda4067575facddcea0e99ac41139670a > Cr-Commit-Position: refs/heads/master@{#403677} TBR=pkotwicz@chromium.org,yfriedman@chromium.org,dominickn@chromium.org,dfalcantara@chromium.org,hanxi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624834 Committed: https://crrev.com/16cafafa820b6a1deababf63d7c24ce5f5e8ecac Cr-Commit-Position: refs/heads/master@{#403733}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
Kunihiko Sakamoto
Created Revert of Use metadata when launching WebAPKs.
4 years, 5 months ago (2016-07-05 02:29:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122813002/1
4 years, 5 months ago (2016-07-05 02:29:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 02:30:21 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 02:32:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16cafafa820b6a1deababf63d7c24ce5f5e8ecac
Cr-Commit-Position: refs/heads/master@{#403733}

Powered by Google App Engine
This is Rietveld 408576698