Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java

Issue 2122813002: Revert of Use metadata when launching WebAPKs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java
index 9f23fd256ffd7afce87534397a707883d91e82ca..b9b446e5c42e75e08fff1b2ea7b2b39699294ab6 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java
@@ -153,8 +153,8 @@
WebappInfo info = WebappInfo.create(id, url, null, name, shortName,
WebDisplayMode.Standalone, ScreenOrientationValues.DEFAULT,
ShortcutSource.UNKNOWN, themeColor, backgroundColor, false, null);
- assertEquals(themeColor, info.themeColor());
- assertEquals(backgroundColor, info.backgroundColor());
+ assertEquals(info.themeColor(), themeColor);
+ assertEquals(info.backgroundColor(), backgroundColor);
}
@SmallTest
@@ -169,8 +169,8 @@
WebDisplayMode.Standalone, ScreenOrientationValues.DEFAULT, ShortcutSource.UNKNOWN,
ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING,
ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, false, null);
- assertEquals(ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, info.themeColor());
- assertEquals(ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING, info.backgroundColor());
+ assertEquals(info.themeColor(), ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING);
+ assertEquals(info.backgroundColor(), ShortcutHelper.MANIFEST_COLOR_INVALID_OR_MISSING);
}
@SmallTest
@@ -184,8 +184,8 @@
intent.putExtra(ShortcutHelper.EXTRA_BACKGROUND_COLOR, backgroundColor);
WebappInfo info = WebappInfo.create(intent);
- assertEquals(themeColor, info.themeColor());
- assertEquals(backgroundColor, info.backgroundColor());
+ assertEquals(info.themeColor(), themeColor);
+ assertEquals(info.backgroundColor(), backgroundColor);
}
@SmallTest
@@ -316,29 +316,6 @@
WebappInfo info = WebappInfo.create(intent);
assertEquals(packageName, info.webApkPackageName());
- }
-
- @SmallTest
- @Feature({"Webapps"})
- public void testUpdateThemeColorAndOrientation() {
- long themeColor = 0xFF00FF00L;
- int orientation = ScreenOrientationValues.DEFAULT;
-
- Intent intent = createIntentWithUrlAndId();
- intent.putExtra(ShortcutHelper.EXTRA_THEME_COLOR, themeColor);
- intent.putExtra(ShortcutHelper.EXTRA_ORIENTATION, orientation);
-
- WebappInfo info = WebappInfo.create(intent);
- assertEquals(themeColor, info.themeColor());
- assertEquals(orientation, info.orientation());
-
- // Updates the theme color and orientation.
- themeColor = 0xFF0000FFL;
- orientation = ScreenOrientationValues.LANDSCAPE;
- info.updateThemeColor(themeColor);
- info.updateOrientation(orientation);
- assertEquals(themeColor, info.themeColor());
- assertEquals(orientation, info.orientation());
}
/**

Powered by Google App Engine
This is Rietveld 408576698