Handle symbols in FrameMirror#invocationText().

Handle symbols in FrameMirror#invocationText().

Fix a TypeError when putting together the invocationText for a symbol
method's stack frame.

See https://github.com/nodejs/node/issues/7536.

Committed: https://crrev.com/1f53e42bd659aca9c2d81e858b410c1d25da9057
Cr-Commit-Position: refs/heads/master@{#37597}

[noordhuis, 2016-07-05 15:54:17]

info@bnoordhuis.nl changed reviewers:
+ info@bnoordhuis.nl, yangguo@chromium.org

[Yang, 2016-07-06 05:39:29]

lgtm.

https://codereview.chromium.org/2122793003/diff/1/test/mjsunit/debug-backtrac...
File test/mjsunit/debug-backtrace-text.js (right):

https://codereview.chromium.org/2122793003/diff/1/test/mjsunit/debug-backtrac...
test/mjsunit/debug-backtrace-text.js:78: // 0: Call distance on Point where
distance is a property on the prototype
Since you already did the work below, how about also keep the 80-char limit
here.

[noordhuis, 2016-07-06 07:06:22]

On 2016/07/06 05:39:29, Yang wrote:
> lgtm.
> 
>
https://codereview.chromium.org/2122793003/diff/1/test/mjsunit/debug-backtrac...
> File test/mjsunit/debug-backtrace-text.js (right):
> 
>
https://codereview.chromium.org/2122793003/diff/1/test/mjsunit/debug-backtrac...
> test/mjsunit/debug-backtrace-text.js:78: // 0: Call distance on Point where
> distance is a property on the prototype
> Since you already did the work below, how about also keep the 80-char limit
> here.

Done, and I also fixed an overlong comment.

What is the normal procedure after fix-ups?  Does the reviewer take another look
or is it good to land?

[Yang, 2016-07-06 07:09:41]

On 2016/07/06 07:06:22, noordhuis wrote:
> On 2016/07/06 05:39:29, Yang wrote:
> > lgtm.
> > 
> >
>
https://codereview.chromium.org/2122793003/diff/1/test/mjsunit/debug-backtrac...
> > File test/mjsunit/debug-backtrace-text.js (right):
> > 
> >
>
https://codereview.chromium.org/2122793003/diff/1/test/mjsunit/debug-backtrac...
> > test/mjsunit/debug-backtrace-text.js:78: // 0: Call distance on Point where
> > distance is a property on the prototype
> > Since you already did the work below, how about also keep the 80-char limit
> > here.
> 
> Done, and I also fixed an overlong comment.
> 
> What is the normal procedure after fix-ups?  Does the reviewer take another
look
> or is it good to land?

For small nits a preceding LGTM is sufficient. Just click on commit to land :)

[bnoordhuis, 2016-07-06 13:49:45]

The CQ bit was checked by ben@strongloop.com

[commit-bot: I haz the power, 2016-07-06 13:49:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 14:03:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 14:03:55]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/8564)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[bnoordhuis, 2016-07-07 21:06:49]

The CQ bit was checked by ben@strongloop.com

[bnoordhuis, 2016-07-07 21:06:50]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2122793003/#ps40001
(title: "Handle symbols in FrameMirror#invocationText().")

[commit-bot: I haz the power, 2016-07-07 21:06:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 21:29:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-07 21:32:10]

Description was changed from

==========
Handle symbols in FrameMirror#invocationText().

Fix a TypeError when putting together the invocationText for a symbol
method's stack frame.

See https://github.com/nodejs/node/issues/7536.
==========

to

==========
Handle symbols in FrameMirror#invocationText().

Fix a TypeError when putting together the invocationText for a symbol
method's stack frame.

See https://github.com/nodejs/node/issues/7536.

Committed: https://crrev.com/1f53e42bd659aca9c2d81e858b410c1d25da9057
Cr-Commit-Position: refs/heads/master@{#37597}
==========

[commit-bot: I haz the power, 2016-07-07 21:32:11]

Patchset 3 (id:??) landed as
https://crrev.com/1f53e42bd659aca9c2d81e858b410c1d25da9057
Cr-Commit-Position: refs/heads/master@{#37597}