Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: src/debug/mirrors.js

Issue 2122793003: Handle symbols in FrameMirror#invocationText(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Handle symbols in FrameMirror#invocationText(). Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/debug-backtrace-text.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/mirrors.js
diff --git a/src/debug/mirrors.js b/src/debug/mirrors.js
index adf5133da5e9f7961d8017f5c634f612de498659..c888f8603bc4ceceff55e90914dd9f68749b411a 100644
--- a/src/debug/mirrors.js
+++ b/src/debug/mirrors.js
@@ -1499,6 +1499,12 @@ PropertyMirror.prototype.name = function() {
};
+PropertyMirror.prototype.toText = function() {
+ if (IS_SYMBOL(this.name_)) return %SymbolDescriptiveString(this.name_);
+ return this.name_;
+};
+
+
PropertyMirror.prototype.isIndexed = function() {
for (var i = 0; i < this.name_.length; i++) {
if (this.name_[i] < '0' || '9' < this.name_[i]) {
@@ -2034,10 +2040,10 @@ FrameMirror.prototype.invocationText = function() {
if (display_receiver) {
result += '.';
}
- result += property.name();
+ result += property.toText();
} else {
result += '[';
- result += property.name();
+ result += property.toText();
result += ']';
}
// Also known as - if the name in the function doesn't match the name
« no previous file with comments | « no previous file | test/mjsunit/debug-backtrace-text.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698