Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2122603005: Update Linux eclipse docs for GN (Closed)

Created:
4 years, 5 months ago by Rick Byers
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Linux eclipse docs for GN Committed: https://crrev.com/5c51b6f69f80a809163b342a05cee8136bbd6fa6 Cr-Commit-Position: refs/heads/master@{#415820}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M docs/linux_eclipse_dev.md View 1 chunk +2 lines, -9 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
Rick Byers
Dirk PTAL (since you reviewed https://codereview.chromium.org/1877013002). I've done this myself and everything appears to be ...
4 years, 5 months ago (2016-07-05 14:19:14 UTC) #2
Dirk Pranke
lgtm w/ additional suggestion. https://codereview.chromium.org/2122603005/diff/1/docs/linux_eclipse_dev.md File docs/linux_eclipse_dev.md (left): https://codereview.chromium.org/2122603005/diff/1/docs/linux_eclipse_dev.md#oldcode303 docs/linux_eclipse_dev.md:303: trouble). Eg. for a blink ...
4 years, 5 months ago (2016-07-06 18:19:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122603005/1
4 years, 3 months ago (2016-08-31 23:41:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 00:34:16 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 00:35:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c51b6f69f80a809163b342a05cee8136bbd6fa6
Cr-Commit-Position: refs/heads/master@{#415820}

Powered by Google App Engine
This is Rietveld 408576698