Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1877013002: Update Linux build docs to remove GYP references. (Closed)

Created:
4 years, 8 months ago by brettw
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Linux build docs to remove GYP references. This removes most references to the GYP build from files in docs starting with "linux_". Committed: https://crrev.com/20d800c70e2fd669c0717dd8670feb50faa0be56 Cr-Commit-Position: refs/heads/master@{#386526}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -50 lines) Patch
M docs/linux_build_instructions.md View 3 chunks +4 lines, -11 lines 0 comments Download
M docs/linux_build_instructions_prerequisites.md View 1 chunk +0 lines, -11 lines 0 comments Download
M docs/linux_chromium_arm.md View 1 chunk +0 lines, -5 lines 0 comments Download
M docs/linux_debugging.md View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M docs/linux_eclipse_dev.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M docs/linux_faster_builds.md View 2 chunks +4 lines, -18 lines 0 comments Download
M docs/linux_suid_sandbox.md View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M docs/linux_suid_sandbox_development.md View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
brettw
4 years, 8 months ago (2016-04-11 20:49:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877013002/20001
4 years, 8 months ago (2016-04-11 20:50:28 UTC) #4
Dirk Pranke
lgtm w/ nits. https://codereview.chromium.org/1877013002/diff/20001/docs/linux_debugging.md File docs/linux_debugging.md (right): https://codereview.chromium.org/1877013002/diff/20001/docs/linux_debugging.md#newcode273 docs/linux_debugging.md:273: plitting symbols from the object files. ...
4 years, 8 months ago (2016-04-11 21:51:07 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 22:09:03 UTC) #7
brettw
fixes
4 years, 8 months ago (2016-04-11 23:29:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877013002/40001
4 years, 8 months ago (2016-04-11 23:30:47 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-12 00:10:58 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 00:12:36 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/20d800c70e2fd669c0717dd8670feb50faa0be56
Cr-Commit-Position: refs/heads/master@{#386526}

Powered by Google App Engine
This is Rietveld 408576698