Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2122593002: X87: disable Acosh/ASinh test cases for x87. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: disable Acosh/ASinh test cases for x87. The reason: same as the CL #37371 (Issue 2111493002: X87: disable some sin/cos/expm1/tan test cases for x87.), please refer https://codereview.chromium.org/2111493002 for more details. For Acosh/ASinh test cases, the expected values are pre-defined double precision values, the results generated by C++ function are extended double precision as the extended double precision is default for x87 Gcc compiler and std lib on linux platform. The comparison of different precisons caused some of those test cases failed. This CL disables Acosh/ASinh test cases for x87. BUG= Committed: https://crrev.com/f310a82952bbd1c42449282339f40673e807db64 Cr-Commit-Position: refs/heads/master@{#37516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/unittests/unittests.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-04 04:04:23 UTC) #2
titzer
On 2016/07/04 04:04:23, zhengxing.li wrote: > PTAL, thanks! lgtm
4 years, 5 months ago (2016-07-05 08:29:46 UTC) #3
zhengxing.li
On 2016/07/05 08:29:46, titzer wrote: > On 2016/07/04 04:04:23, zhengxing.li wrote: > > PTAL, thanks! ...
4 years, 5 months ago (2016-07-05 08:32:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122593002/1
4 years, 5 months ago (2016-07-05 08:32:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 08:56:48 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 08:59:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f310a82952bbd1c42449282339f40673e807db64
Cr-Commit-Position: refs/heads/master@{#37516}

Powered by Google App Engine
This is Rietveld 408576698