third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc - Issue 2122543002: Replace Closure in TaskRunner::PostTask with OneShotCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc

Issue 2122543002: Replace Closure in TaskRunner::PostTask with OneShotCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@07_oneshot

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc ('k') | third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc

index e2b7e3c9e28d67b49e0f2ebbcd16a5b079d7f1d2..59b14d29997024c54777acc065b9249520449da6 100644

--- a/third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc

@@ -57,7 +57,7 @@ class IdleTimeEstimatorTest : public testing::Test {

void SimulateFrameWithOneCompositorTask(int compositor_time) {

base::TimeDelta non_idle_time =

base::TimeDelta::FromMilliseconds(compositor_time);

- base::PendingTask task(FROM_HERE, base::Closure());

+ base::PendingTask task(FROM_HERE, base::OnceClosure());

estimator_->WillProcessTask(task);

clock_->Advance(non_idle_time);

estimator_->DidCommitFrameToCompositor();

@@ -72,7 +72,7 @@ class IdleTimeEstimatorTest : public testing::Test {

base::TimeDelta::FromMilliseconds(compositor_time1);

base::TimeDelta non_idle_time2 =

base::TimeDelta::FromMilliseconds(compositor_time2);

- base::PendingTask task(FROM_HERE, base::Closure());

+ base::PendingTask task(FROM_HERE, base::OnceClosure());

estimator_->WillProcessTask(task);

clock_->Advance(non_idle_time1);

estimator_->DidProcessTask(task);

@@ -153,7 +153,7 @@ TEST_F(IdleTimeEstimatorTest, IgnoresNestedTasks) {

SimulateFrameWithOneCompositorTask(5);

- base::PendingTask task(FROM_HERE, base::Closure());

+ base::PendingTask task(FROM_HERE, base::OnceClosure());

estimator_->WillProcessTask(task);

SimulateFrameWithTwoCompositorTasks(4, 4);