Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc

Issue 2122543002: Replace Closure in TaskRunner::PostTask with OneShotCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@07_oneshot
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc b/third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc
index b6df36b69d1396c1047b907738f14b20ded1e693..c90155807dd9a232cf4365d79231a796ae0814c2 100644
--- a/third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc
+++ b/third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc
@@ -37,20 +37,20 @@ bool SingleThreadIdleTaskRunner::RunsTasksOnCurrentThread() const {
void SingleThreadIdleTaskRunner::PostIdleTask(
const tracked_objects::Location& from_here,
- const IdleTask& idle_task) {
+ IdleTask idle_task) {
delegate_->OnIdleTaskPosted();
idle_priority_task_runner_->PostTask(
- from_here, base::Bind(&SingleThreadIdleTaskRunner::RunTask,
- weak_scheduler_ptr_, idle_task));
+ from_here, base::BindOnce(&SingleThreadIdleTaskRunner::RunTask,
+ weak_scheduler_ptr_, std::move(idle_task)));
}
void SingleThreadIdleTaskRunner::PostNonNestableIdleTask(
const tracked_objects::Location& from_here,
- const IdleTask& idle_task) {
+ IdleTask idle_task) {
delegate_->OnIdleTaskPosted();
idle_priority_task_runner_->PostNonNestableTask(
- from_here, base::Bind(&SingleThreadIdleTaskRunner::RunTask,
- weak_scheduler_ptr_, idle_task));
+ from_here, base::BindOnce(&SingleThreadIdleTaskRunner::RunTask,
+ weak_scheduler_ptr_, std::move(idle_task)));
}
void SingleThreadIdleTaskRunner::RunTask(IdleTask idle_task) {
@@ -60,7 +60,7 @@ void SingleThreadIdleTaskRunner::RunTask(IdleTask idle_task) {
(deadline - base::TimeTicks::Now()).InMillisecondsF());
if (blame_context_)
blame_context_->Enter();
- idle_task.Run(deadline);
+ std::move(idle_task).Run(deadline);
if (blame_context_)
blame_context_->Leave();
delegate_->DidProcessIdleTask();

Powered by Google App Engine
This is Rietveld 408576698