third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc - Issue 2122543002: Replace Closure in TaskRunner::PostTask with OneShotCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

Issue 2122543002: Replace Closure in TaskRunner::PostTask with OneShotCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@07_oneshot

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h ('k') | third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_delegate_for_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

index db351c79c3fe52a81049d8c2679f2e014581a695..6b3e73ca7bfdeea636b657b89377f0577459ebcb 100644

--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

@@ -334,7 +334,7 @@ TaskQueueManager::ProcessTaskResult TaskQueueManager::ProcessTaskFromWorkQueue(

internal::TaskQueueImpl* prev_executing_task_queue =

currently_executing_task_queue_;

currently_executing_task_queue_ = queue;

- task_annotator_.RunTask("TaskQueueManager::PostTask", pending_task);

+ task_annotator_.RunTask("TaskQueueManager::PostTask", &pending_task);

// Detect if the TaskQueueManager just got deleted. If this happens we must

// not access any member variables after this point.

if (protect->HasOneRef())