Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: chrome/browser/after_startup_task_utils_unittest.cc

Issue 2122543002: Replace Closure in TaskRunner::PostTask with OneShotCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@07_oneshot
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/after_startup_task_utils.cc ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/after_startup_task_utils_unittest.cc
diff --git a/chrome/browser/after_startup_task_utils_unittest.cc b/chrome/browser/after_startup_task_utils_unittest.cc
index c1433b7211fd2e4bc873df6568bd7d12d718ca79..5943d6d72f6cb7c77c92fe2eb039abff570465fa 100644
--- a/chrome/browser/after_startup_task_utils_unittest.cc
+++ b/chrome/browser/after_startup_task_utils_unittest.cc
@@ -30,11 +30,12 @@ class WrappedTaskRunner : public base::TaskRunner {
: real_task_runner_(real_runner) {}
bool PostDelayedTask(const tracked_objects::Location& from_here,
- const base::Closure& task,
+ base::OnceClosure task,
base::TimeDelta delay) override {
++posted_task_count_;
return real_task_runner_->PostDelayedTask(
- from_here, base::Bind(&WrappedTaskRunner::RunWrappedTask, this, task),
+ from_here, base::BindOnce(&WrappedTaskRunner::RunWrappedTask, this,
+ std::move(task)),
base::TimeDelta()); // Squash all delays so our tests complete asap.
}
@@ -56,9 +57,9 @@ class WrappedTaskRunner : public base::TaskRunner {
private:
~WrappedTaskRunner() override {}
- void RunWrappedTask(const base::Closure& task) {
+ void RunWrappedTask(base::OnceClosure task) {
++ran_task_count_;
- task.Run();
+ std::move(task).Run();
}
scoped_refptr<TaskRunner> real_task_runner_;
« no previous file with comments | « chrome/browser/after_startup_task_utils.cc ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698