Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: base/deferred_sequenced_task_runner.cc

Issue 2122543002: Replace Closure in TaskRunner::PostTask with OneShotCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@07_oneshot
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/deferred_sequenced_task_runner.h ('k') | base/files/file_util_proxy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/deferred_sequenced_task_runner.h" 5 #include "base/deferred_sequenced_task_runner.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 9
10 namespace base { 10 namespace base {
11 11
12 DeferredSequencedTaskRunner::DeferredTask::DeferredTask() 12 DeferredSequencedTaskRunner::DeferredTask::DeferredTask()
13 : is_non_nestable(false) { 13 : is_non_nestable(false) {
14 } 14 }
15 15
16 DeferredSequencedTaskRunner::DeferredTask::DeferredTask( 16 DeferredSequencedTaskRunner::DeferredTask::DeferredTask(DeferredTask&& other) =
17 const DeferredTask& other) = default; 17 default;
18 18
19 DeferredSequencedTaskRunner::DeferredTask::~DeferredTask() { 19 DeferredSequencedTaskRunner::DeferredTask::~DeferredTask() {
20 } 20 }
21 21
22 DeferredSequencedTaskRunner::DeferredTask&
23 DeferredSequencedTaskRunner::DeferredTask::operator=(DeferredTask&& other) =
24 default;
25
22 DeferredSequencedTaskRunner::DeferredSequencedTaskRunner( 26 DeferredSequencedTaskRunner::DeferredSequencedTaskRunner(
23 scoped_refptr<SequencedTaskRunner> target_task_runner) 27 scoped_refptr<SequencedTaskRunner> target_task_runner)
24 : started_(false), target_task_runner_(std::move(target_task_runner)) {} 28 : started_(false), target_task_runner_(std::move(target_task_runner)) {}
25 29
26 DeferredSequencedTaskRunner::~DeferredSequencedTaskRunner() { 30 DeferredSequencedTaskRunner::~DeferredSequencedTaskRunner() {
27 } 31 }
28 32
29 bool DeferredSequencedTaskRunner::PostDelayedTask( 33 bool DeferredSequencedTaskRunner::PostDelayedTask(
30 const tracked_objects::Location& from_here, 34 const tracked_objects::Location& from_here,
31 const Closure& task, 35 OnceClosure task,
32 TimeDelta delay) { 36 TimeDelta delay) {
33 AutoLock lock(lock_); 37 AutoLock lock(lock_);
34 if (started_) { 38 if (started_) {
35 DCHECK(deferred_tasks_queue_.empty()); 39 DCHECK(deferred_tasks_queue_.empty());
36 return target_task_runner_->PostDelayedTask(from_here, task, delay); 40 return target_task_runner_->PostDelayedTask(from_here, std::move(task),
41 delay);
37 } 42 }
38 43
39 QueueDeferredTask(from_here, task, delay, false /* is_non_nestable */); 44 QueueDeferredTask(from_here, std::move(task), delay,
45 false /* is_non_nestable */);
40 return true; 46 return true;
41 } 47 }
42 48
43 bool DeferredSequencedTaskRunner::RunsTasksOnCurrentThread() const { 49 bool DeferredSequencedTaskRunner::RunsTasksOnCurrentThread() const {
44 return target_task_runner_->RunsTasksOnCurrentThread(); 50 return target_task_runner_->RunsTasksOnCurrentThread();
45 } 51 }
46 52
47 bool DeferredSequencedTaskRunner::PostNonNestableDelayedTask( 53 bool DeferredSequencedTaskRunner::PostNonNestableDelayedTask(
48 const tracked_objects::Location& from_here, 54 const tracked_objects::Location& from_here,
49 const Closure& task, 55 OnceClosure task,
50 TimeDelta delay) { 56 TimeDelta delay) {
51 AutoLock lock(lock_); 57 AutoLock lock(lock_);
52 if (started_) { 58 if (started_) {
53 DCHECK(deferred_tasks_queue_.empty()); 59 DCHECK(deferred_tasks_queue_.empty());
54 return target_task_runner_->PostNonNestableDelayedTask(from_here, 60 return target_task_runner_->PostNonNestableDelayedTask(
55 task, 61 from_here, std::move(task), delay);
56 delay);
57 } 62 }
58 QueueDeferredTask(from_here, task, delay, true /* is_non_nestable */); 63 QueueDeferredTask(from_here, std::move(task), delay,
64 true /* is_non_nestable */);
59 return true; 65 return true;
60 } 66 }
61 67
62 void DeferredSequencedTaskRunner::QueueDeferredTask( 68 void DeferredSequencedTaskRunner::QueueDeferredTask(
63 const tracked_objects::Location& from_here, 69 const tracked_objects::Location& from_here,
64 const Closure& task, 70 OnceClosure task,
65 TimeDelta delay, 71 TimeDelta delay,
66 bool is_non_nestable) { 72 bool is_non_nestable) {
67 DeferredTask deferred_task; 73 DeferredTask deferred_task;
68 deferred_task.posted_from = from_here; 74 deferred_task.posted_from = from_here;
69 deferred_task.task = task; 75 deferred_task.task = std::move(task);
70 deferred_task.delay = delay; 76 deferred_task.delay = delay;
71 deferred_task.is_non_nestable = is_non_nestable; 77 deferred_task.is_non_nestable = is_non_nestable;
72 deferred_tasks_queue_.push_back(deferred_task); 78 deferred_tasks_queue_.push_back(std::move(deferred_task));
73 } 79 }
74 80
75 81
76 void DeferredSequencedTaskRunner::Start() { 82 void DeferredSequencedTaskRunner::Start() {
77 AutoLock lock(lock_); 83 AutoLock lock(lock_);
78 DCHECK(!started_); 84 DCHECK(!started_);
79 started_ = true; 85 started_ = true;
80 for (std::vector<DeferredTask>::iterator i = deferred_tasks_queue_.begin(); 86 for (std::vector<DeferredTask>::iterator i = deferred_tasks_queue_.begin();
81 i != deferred_tasks_queue_.end(); 87 i != deferred_tasks_queue_.end();
82 ++i) { 88 ++i) {
83 const DeferredTask& task = *i; 89 const DeferredTask& task = *i;
84 if (task.is_non_nestable) { 90 if (task.is_non_nestable) {
85 target_task_runner_->PostNonNestableDelayedTask(task.posted_from, 91 target_task_runner_->PostNonNestableDelayedTask(
86 task.task, 92 task.posted_from, std::move(task.task), task.delay);
87 task.delay);
88 } else { 93 } else {
89 target_task_runner_->PostDelayedTask(task.posted_from, 94 target_task_runner_->PostDelayedTask(task.posted_from,
90 task.task, 95 std::move(task.task), task.delay);
91 task.delay);
92 } 96 }
93 // Replace the i-th element in the |deferred_tasks_queue_| with an empty 97 // Replace the i-th element in the |deferred_tasks_queue_| with an empty
94 // |DelayedTask| to ensure that |task| is destroyed before the next task 98 // |DelayedTask| to ensure that |task| is destroyed before the next task
95 // is posted. 99 // is posted.
96 *i = DeferredTask(); 100 *i = DeferredTask();
97 } 101 }
98 deferred_tasks_queue_.clear(); 102 deferred_tasks_queue_.clear();
99 } 103 }
100 104
101 } // namespace base 105 } // namespace base
OLDNEW
« no previous file with comments | « base/deferred_sequenced_task_runner.h ('k') | base/files/file_util_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698