Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 21224003: Optimize the blur convolution by only applying domain clamping where necessary. Split the blur con… (Closed)

Created:
7 years, 4 months ago by Stephen White
Modified:
7 years, 4 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Optimize the blur convolution by only applying domain clamping where necessary. Split the blur convolution into left and right margins which have clamping applied and a center portion which doesn't. Also reorder the convolve_gaussian() parameters to match GrConvolutionEffect params. Correctness is covered by existing tests; performance is covered by BlurImageFilter bench. R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=10444

Patch Set 1 #

Patch Set 2 : Win32 fixes: SkScalar correctness. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -25 lines) Patch
M src/effects/SkGpuBlurUtils.cpp View 1 3 chunks +67 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Stephen White
Brian: PTAL. Thanks!
7 years, 4 months ago (2013-07-30 19:02:51 UTC) #1
bsalomon
lgtm, but could you give the two convolve_gaussian functions different names? Even something like convolve_gaussian_helper(). ...
7 years, 4 months ago (2013-07-30 20:53:43 UTC) #2
Stephen White
On 2013/07/30 20:53:43, bsalomon wrote: > lgtm, but could you give the two convolve_gaussian functions ...
7 years, 4 months ago (2013-07-30 21:04:54 UTC) #3
Stephen White
7 years, 4 months ago (2013-07-30 21:11:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r10444 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698