Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/win/chrome_select_file_dialog_factory.h

Issue 2122303002: Revive experiment to isolate shell operations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/win/chrome_select_file_dialog_factory.h
diff --git a/chrome/browser/win/chrome_select_file_dialog_factory.h b/chrome/browser/win/chrome_select_file_dialog_factory.h
index b1d8745f19e9d7f212d91086f3a379a270125e1e..339503071650d7bac6333a97e7879be872658873 100644
--- a/chrome/browser/win/chrome_select_file_dialog_factory.h
+++ b/chrome/browser/win/chrome_select_file_dialog_factory.h
@@ -5,33 +5,22 @@
#ifndef CHROME_BROWSER_WIN_CHROME_SELECT_FILE_DIALOG_FACTORY_H_
#define CHROME_BROWSER_WIN_CHROME_SELECT_FILE_DIALOG_FACTORY_H_
-#include "base/compiler_specific.h"
#include "base/macros.h"
-#include "base/memory/ref_counted.h"
#include "ui/shell_dialogs/select_file_dialog_factory.h"
-namespace base {
-class SequencedTaskRunner;
-} // namespace base
-
// Implements a Select File dialog that delegates to a Metro file picker on
// Metro and to a utility process otherwise. The utility process is used in
// order to isolate the Chrome browser process from potential instability
// caused by Shell extension modules loaded by GetOpenFileName.
class ChromeSelectFileDialogFactory : public ui::SelectFileDialogFactory {
public:
- // Uses |blocking_task_runner| to perform IPC with the utility process.
- explicit ChromeSelectFileDialogFactory(
- const scoped_refptr<base::SequencedTaskRunner>& blocking_task_runner);
- ~ChromeSelectFileDialogFactory() override;
+ ChromeSelectFileDialogFactory();
sky 2016/07/08 15:28:20 nit: don't inline the destructor.
Patrick Monette 2016/07/08 19:36:10 Done.
// ui::SelectFileDialogFactory implementation
ui::SelectFileDialog* Create(ui::SelectFileDialog::Listener* listener,
ui::SelectFilePolicy* policy) override;
private:
- scoped_refptr<base::SequencedTaskRunner> blocking_task_runner_;
-
DISALLOW_COPY_AND_ASSIGN(ChromeSelectFileDialogFactory);
};

Powered by Google App Engine
This is Rietveld 408576698