Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: chrome/browser/win/chrome_select_file_dialog_factory.h

Issue 2122303002: Revive experiment to isolate shell operations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_WIN_CHROME_SELECT_FILE_DIALOG_FACTORY_H_ 5 #ifndef CHROME_BROWSER_WIN_CHROME_SELECT_FILE_DIALOG_FACTORY_H_
6 #define CHROME_BROWSER_WIN_CHROME_SELECT_FILE_DIALOG_FACTORY_H_ 6 #define CHROME_BROWSER_WIN_CHROME_SELECT_FILE_DIALOG_FACTORY_H_
7 7
8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 8 #include "base/macros.h"
10 #include "base/memory/ref_counted.h"
11 #include "ui/shell_dialogs/select_file_dialog_factory.h" 9 #include "ui/shell_dialogs/select_file_dialog_factory.h"
12 10
13 namespace base {
14 class SequencedTaskRunner;
15 } // namespace base
16
17 // Implements a Select File dialog that delegates to a Metro file picker on 11 // Implements a Select File dialog that delegates to a Metro file picker on
18 // Metro and to a utility process otherwise. The utility process is used in 12 // Metro and to a utility process otherwise. The utility process is used in
19 // order to isolate the Chrome browser process from potential instability 13 // order to isolate the Chrome browser process from potential instability
20 // caused by Shell extension modules loaded by GetOpenFileName. 14 // caused by Shell extension modules loaded by GetOpenFileName.
21 class ChromeSelectFileDialogFactory : public ui::SelectFileDialogFactory { 15 class ChromeSelectFileDialogFactory : public ui::SelectFileDialogFactory {
22 public: 16 public:
23 // Uses |blocking_task_runner| to perform IPC with the utility process. 17 ChromeSelectFileDialogFactory();
sky 2016/07/08 15:28:20 nit: don't inline the destructor.
Patrick Monette 2016/07/08 19:36:10 Done.
24 explicit ChromeSelectFileDialogFactory(
25 const scoped_refptr<base::SequencedTaskRunner>& blocking_task_runner);
26 ~ChromeSelectFileDialogFactory() override;
27 18
28 // ui::SelectFileDialogFactory implementation 19 // ui::SelectFileDialogFactory implementation
29 ui::SelectFileDialog* Create(ui::SelectFileDialog::Listener* listener, 20 ui::SelectFileDialog* Create(ui::SelectFileDialog::Listener* listener,
30 ui::SelectFilePolicy* policy) override; 21 ui::SelectFilePolicy* policy) override;
31 22
32 private: 23 private:
33 scoped_refptr<base::SequencedTaskRunner> blocking_task_runner_;
34
35 DISALLOW_COPY_AND_ASSIGN(ChromeSelectFileDialogFactory); 24 DISALLOW_COPY_AND_ASSIGN(ChromeSelectFileDialogFactory);
36 }; 25 };
37 26
38 #endif // CHROME_BROWSER_WIN_CHROME_SELECT_FILE_DIALOG_FACTORY_H_ 27 #endif // CHROME_BROWSER_WIN_CHROME_SELECT_FILE_DIALOG_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698