Disable app list folders by default for non-ChromeOS platforms.

Disable app list folders by default for non-ChromeOS platforms.

This CL disables app launcher folders for non-ChromeOS platforms.
Non-ChromeOS platforms now need to enable folders via the
--enable-app-list-folder-ui switch.

This has also been added to chrome://flags.

BUG=358944
TBR=zea@chromium.org

[benwells, 2014-04-02 03:59:58]

https://codereview.chromium.org/212223012/diff/20001/chrome/browser/about_fla...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/212223012/diff/20001/chrome/browser/about_fla...
chrome/browser/about_flags.cc:1533: #if defined(OS_CHROMEOS)
Why guard this in #if, it is already guarded with the kOsCrOS thing?

[calamity, 2014-04-02 04:23:16]

https://codereview.chromium.org/212223012/diff/20001/chrome/browser/about_fla...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/212223012/diff/20001/chrome/browser/about_fla...
chrome/browser/about_flags.cc:1533: #if defined(OS_CHROMEOS)
On 2014/04/02 03:59:58, benwells wrote:
> Why guard this in #if, it is already guarded with the kOsCrOS thing?

Similar reason to --enable-app-list above. It would be visible in the bottom
section of the chrome://flags page.

I suppose the other option is to make it a combobox?

[tapted, 2014-04-02 04:32:08]

https://codereview.chromium.org/212223012/diff/80001/chrome/browser/about_fla...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/212223012/diff/80001/chrome/browser/about_fla...
chrome/browser/about_flags.cc:1545: kOsWin | kOsLinux | kOsCrOS,
drive-by: This should be kOsAll. Otherwise when it's default-enabled again, mac
users will have no way to disable it!

[calamity, 2014-04-02 04:53:53]

Also appended the enable switch for some unit tests.

https://codereview.chromium.org/212223012/diff/80001/chrome/browser/about_fla...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/212223012/diff/80001/chrome/browser/about_fla...
chrome/browser/about_flags.cc:1545: kOsWin | kOsLinux | kOsCrOS,
On 2014/04/02 04:32:08, tapted wrote:
> drive-by: This should be kOsAll. Otherwise when it's default-enabled again,
mac
> users will have no way to disable it!

Done.

[benwells, 2014-04-02 05:07:33]

lgtm.

Not sure I agree with tapted@'s comment. With kOsAll mac users will get a flag
which does nothing and will seem broken.

I have a preference for keeping the flag kOSTheThreeOSes, and keeping forcing
IsFolderUIEnabled -> false for mac that stevenjb added. But I'll let you decide.

[calamity, 2014-04-02 05:24:42]

On 2014/04/02 05:07:33, benwells wrote:
> lgtm.
> 
> Not sure I agree with tapted@'s comment. With kOsAll mac users will get a flag
> which does nothing and will seem broken.
> 
> I have a preference for keeping the flag kOSTheThreeOSes, and keeping forcing
> IsFolderUIEnabled -> false for mac that stevenjb added. But I'll let you
decide.

Hmmmm. Since some app_list_unittests rely on folders being present, forcing
false
will break app_list_unittests on mac if they ever run. I think it's reasonable
to have break-y, weird flags in chrome:flags. I'll usurp stevenjb's
change with this one.

[calamity, 2014-04-02 05:41:19]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-04-02 05:41:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/212223012/100001

[commit-bot: I haz the power, 2014-04-02 06:26:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 06:26:55]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[calamity, 2014-04-02 07:11:11]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-04-02 07:11:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/212223012/100001

[commit-bot: I haz the power, 2014-04-02 07:46:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 07:46:33]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[benwells, 2014-04-02 08:21:03]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2014-04-02 08:21:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/212223012/100001

[commit-bot: I haz the power, 2014-04-02 09:37:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 09:37:10]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[calamity, 2014-04-02 23:29:26]

TBR zea for sync integration tests.

[calamity, 2014-04-02 23:30:16]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-04-02 23:33:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/212223012/110001

[stevenjb, 2014-04-02 23:47:45]

The CQ bit was unchecked by stevenjb@chromium.org

[stevenjb, 2014-04-03 00:36:53]

This CL is superceeded by https://codereview.chromium.org/222553003/