Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 212223012: Disable app list folders by default for non-ChromeOS platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix android compile, sync_integration_tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 switches::kTouchScrollingMode, 394 switches::kTouchScrollingMode,
395 switches::kTouchScrollingModeTouchcancel }, 395 switches::kTouchScrollingModeTouchcancel },
396 { IDS_FLAGS_TOUCH_SCROLLING_MODE_ABSORB_TOUCHMOVE, 396 { IDS_FLAGS_TOUCH_SCROLLING_MODE_ABSORB_TOUCHMOVE,
397 switches::kTouchScrollingMode, 397 switches::kTouchScrollingMode,
398 switches::kTouchScrollingModeAbsorbTouchmove }, 398 switches::kTouchScrollingModeAbsorbTouchmove },
399 { IDS_FLAGS_TOUCH_SCROLLING_MODE_SYNC_TOUCHMOVE, 399 { IDS_FLAGS_TOUCH_SCROLLING_MODE_SYNC_TOUCHMOVE,
400 switches::kTouchScrollingMode, 400 switches::kTouchScrollingMode,
401 switches::kTouchScrollingModeSyncTouchmove }, 401 switches::kTouchScrollingModeSyncTouchmove },
402 }; 402 };
403 403
404 #if defined(ENABLE_APP_LIST)
405 const Experiment::Choice kEnableAppListFoldersChoices[] = {
406 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
407 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
408 app_list::switches::kEnableFolderUI, "" },
409 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
410 app_list::switches::kDisableFolderUI, "" },
411 };
412 #endif
413
404 // RECORDING USER METRICS FOR FLAGS: 414 // RECORDING USER METRICS FOR FLAGS:
405 // ----------------------------------------------------------------------------- 415 // -----------------------------------------------------------------------------
406 // The first line of the experiment is the internal name. If you'd like to 416 // The first line of the experiment is the internal name. If you'd like to
407 // gather statistics about the usage of your flag, you should append a marker 417 // gather statistics about the usage of your flag, you should append a marker
408 // comment to the end of the feature name, like so: 418 // comment to the end of the feature name, like so:
409 // "my-special-feature", // FLAGS:RECORD_UMA 419 // "my-special-feature", // FLAGS:RECORD_UMA
410 // 420 //
411 // After doing that, run 421 // After doing that, run
412 // tools/metrics/actions/extract_actions.py 422 // tools/metrics/actions/extract_actions.py
413 // to add the metric to actions.xml (which will enable UMA to record your 423 // to add the metric to actions.xml (which will enable UMA to record your
(...skipping 1103 matching lines...) Expand 10 before | Expand all | Expand 10 after
1517 // visible on Win/Mac/CrOS but not on Linux GTK, which would be confusing. 1527 // visible on Win/Mac/CrOS but not on Linux GTK, which would be confusing.
1518 // TODO(mgiuca): Remove the #if when Aura is the default on Linux. 1528 // TODO(mgiuca): Remove the #if when Aura is the default on Linux.
1519 "enable-app-list", 1529 "enable-app-list",
1520 IDS_FLAGS_ENABLE_APP_LIST_NAME, 1530 IDS_FLAGS_ENABLE_APP_LIST_NAME,
1521 IDS_FLAGS_ENABLE_APP_LIST_DESCRIPTION, 1531 IDS_FLAGS_ENABLE_APP_LIST_DESCRIPTION,
1522 kOsLinux, 1532 kOsLinux,
1523 SINGLE_VALUE_TYPE(switches::kEnableAppList) 1533 SINGLE_VALUE_TYPE(switches::kEnableAppList)
1524 }, 1534 },
1525 #endif 1535 #endif
1526 { 1536 {
1527 "disable-app-list-folder-ui", 1537 "app-list-folder-ui",
1528 IDS_FLAGS_DISABLE_APP_LIST_FOLDER, 1538 IDS_FLAGS_ENABLE_APP_LIST_FOLDER,
1529 IDS_FLAGS_DISABLE_APP_LIST_FOLDER_DESCRIPTION, 1539 IDS_FLAGS_ENABLE_APP_LIST_FOLDER_DESCRIPTION,
1530 kOsWin | kOsLinux | kOsCrOS, 1540 kOsAll,
1531 SINGLE_VALUE_TYPE(app_list::switches::kDisableFolderUI) 1541 MULTI_VALUE_TYPE(kEnableAppListFoldersChoices)
1532 }, 1542 },
1533 { 1543 {
1534 "disable-app-list-voice-search", 1544 "disable-app-list-voice-search",
1535 IDS_FLAGS_DISABLE_APP_LIST_VOICE_SEARCH, 1545 IDS_FLAGS_DISABLE_APP_LIST_VOICE_SEARCH,
1536 IDS_FLAGS_DISABLE_APP_LIST_VOICE_SEARCH_DESCRIPTION, 1546 IDS_FLAGS_DISABLE_APP_LIST_VOICE_SEARCH_DESCRIPTION,
1537 kOsCrOS, 1547 kOsCrOS,
1538 SINGLE_VALUE_TYPE(app_list::switches::kDisableVoiceSearch) 1548 SINGLE_VALUE_TYPE(app_list::switches::kDisableVoiceSearch)
1539 }, 1549 },
1540 { 1550 {
1541 "enable-app-list-hotword-always-on", 1551 "enable-app-list-hotword-always-on",
(...skipping 824 matching lines...) Expand 10 before | Expand all | Expand 10 after
2366 } 2376 }
2367 2377
2368 const Experiment* GetExperiments(size_t* count) { 2378 const Experiment* GetExperiments(size_t* count) {
2369 *count = num_experiments; 2379 *count = num_experiments;
2370 return experiments; 2380 return experiments;
2371 } 2381 }
2372 2382
2373 } // namespace testing 2383 } // namespace testing
2374 2384
2375 } // namespace about_flags 2385 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698