Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212223003: DevTools: Introduce WebInspector.RegExpSetting. (Closed)

Created:
6 years, 9 months ago by aandrey
Modified:
6 years, 9 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Introduce WebInspector.RegExpSetting. R=vsevik@chromium.org, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170035

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -11 lines) Patch
M Source/devtools/front_end/FileSystemMapping.js View 3 chunks +3 lines, -9 lines 0 comments Download
M Source/devtools/front_end/Settings.js View 1 2 4 chunks +55 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aandrey
6 years, 9 months ago (2014-03-26 08:44:46 UTC) #1
vsevik
lgtm https://chromiumcodereview.appspot.com/212223003/diff/1/Source/devtools/front_end/Settings.js File Source/devtools/front_end/Settings.js (right): https://chromiumcodereview.appspot.com/212223003/diff/1/Source/devtools/front_end/Settings.js#newcode250 Source/devtools/front_end/Settings.js:250: this.addChangeListener(this._valueChanged, this); I've heard it's a bad practice ...
6 years, 9 months ago (2014-03-26 08:51:46 UTC) #2
vsevik
https://chromiumcodereview.appspot.com/212223003/diff/1/Source/devtools/front_end/Settings.js File Source/devtools/front_end/Settings.js (right): https://chromiumcodereview.appspot.com/212223003/diff/1/Source/devtools/front_end/Settings.js#newcode109 Source/devtools/front_end/Settings.js:109: this.skipStackFramesPattern = this.createRegExpSetting("skipStackFramesPattern", ""); I assume this change fine ...
6 years, 9 months ago (2014-03-26 08:53:18 UTC) #3
aandrey
https://chromiumcodereview.appspot.com/212223003/diff/1/Source/devtools/front_end/Settings.js File Source/devtools/front_end/Settings.js (right): https://chromiumcodereview.appspot.com/212223003/diff/1/Source/devtools/front_end/Settings.js#newcode109 Source/devtools/front_end/Settings.js:109: this.skipStackFramesPattern = this.createRegExpSetting("skipStackFramesPattern", ""); On 2014/03/26 08:53:18, vsevik wrote: ...
6 years, 9 months ago (2014-03-26 09:13:46 UTC) #4
aandrey
6 years, 9 months ago (2014-03-26 09:22:12 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r170035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698