Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.
Issue 2122073004: Display extension name on device chooser title (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_chooser_controller_to_chrome_browser
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index b3c9b5e45debe7353755bccd5386fe912c2c9951..790013feb4d676e1804cf5046ee5acd684b0c1dd 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -14863,9 +14863,12 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex
<if expr="not is_android and not is_ios">
<!-- Device Chooser Prompt -->
- <message name="IDS_DEVICE_CHOOSER_PROMPT" desc="The label that is used to introduce chooser details to the user in a popup.">
+ <message name="IDS_DEVICE_CHOOSER_PROMPT_ORIGIN" desc="The label that is used to introduce chooser details to the user in a popup.">
<ph name="Origin">$1<ex>www.google.com</ex></ph> wants to connect to:
</message>
+ <message name="IDS_DEVICE_CHOOSER_PROMPT_EXTENSION_NAME" desc="The label that is used to introduce chooser details to the user in a popup.">
Reilly Grant (use Gerrit) 2016/07/11 23:31:40 nit: These message descriptions should explain why
juncai 2016/07/12 00:00:42 Done.
+ <ph name="CHROME_EXTENSION_NAME">"$1"<ex>Chrome extension name</ex></ph> wants to connect to:
Reilly Grant (use Gerrit) 2016/07/11 23:31:40 This might work but most other examples put the qu
juncai 2016/07/12 00:00:42 Done.
+ </message>
<message name="IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT" desc="The label that is used to inform the user that no devices were found in the chooser popup.">
No devices found.
</message>

Powered by Google App Engine
This is Rietveld 408576698