Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2113)

Unified Diff: chrome/browser/chooser_controller/chooser_controller.h

Issue 2122073004: Display extension name on device chooser title (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_chooser_controller_to_chrome_browser
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chooser_controller/chooser_controller.h
diff --git a/chrome/browser/chooser_controller/chooser_controller.h b/chrome/browser/chooser_controller/chooser_controller.h
index 275f02431810e363f886b54a0fced92cc7ae5263..2982e0168804e4a383ec5a1099556191eea81534 100644
--- a/chrome/browser/chooser_controller/chooser_controller.h
+++ b/chrome/browser/chooser_controller/chooser_controller.h
@@ -52,8 +52,8 @@ class ChooserController {
virtual ~Observer() {}
};
- // Return the origin URL to be displayed on the chooser title.
- url::Origin GetOrigin() const;
+ // Returns the text to be displayed in the chooser title.
+ base::string16 GetTitle();
// The number of options users can pick from. For example, it can be
// the number of USB/Bluetooth device names which are listed in the
@@ -82,8 +82,13 @@ class ChooserController {
void set_observer(Observer* observer) { observer_ = observer; }
Observer* observer() const { return observer_; }
+ protected:
+ // Return the title prefix to be displayed on the chooser.
+ base::string16 GetTitlePrefix();
+
private:
content::RenderFrameHost* owning_frame_;
+ bool title_prefix_has_quote_ = true;
Observer* observer_ = nullptr;
DISALLOW_COPY_AND_ASSIGN(ChooserController);

Powered by Google App Engine
This is Rietveld 408576698