Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: Source/modules/webaudio/ScriptProcessorNode.h

Issue 212183002: Fix potential thread safety issue on ScriptProcessNdoe during fire onaudioprocess eventhandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/webaudio/ScriptProcessorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/ScriptProcessorNode.h
diff --git a/Source/modules/webaudio/ScriptProcessorNode.h b/Source/modules/webaudio/ScriptProcessorNode.h
index 515059fe0d4dc1db4647e27e224bdd8cabdebd8b..08a187df65576382d6bb8b5c43f893d02af020f8 100644
--- a/Source/modules/webaudio/ScriptProcessorNode.h
+++ b/Source/modules/webaudio/ScriptProcessorNode.h
@@ -83,12 +83,14 @@ private:
size_t m_bufferSize;
unsigned m_bufferReadWriteIndex;
- volatile bool m_isRequestOutstanding;
unsigned m_numberOfInputChannels;
unsigned m_numberOfOutputChannels;
RefPtr<AudioBus> m_internalInputBus;
+
+ // Synchronize process() with fireProcessEvent().
+ mutable Mutex m_processEventLock;
};
} // namespace WebCore
« no previous file with comments | « no previous file | Source/modules/webaudio/ScriptProcessorNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698