Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: Source/modules/webaudio/ScriptProcessorNode.h

Issue 212183002: Fix potential thread safety issue on ScriptProcessNdoe during fire onaudioprocess eventhandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/modules/webaudio/ScriptProcessorNode.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 // Double buffering 76 // Double buffering
77 unsigned doubleBufferIndex() const { return m_doubleBufferIndex; } 77 unsigned doubleBufferIndex() const { return m_doubleBufferIndex; }
78 void swapBuffers() { m_doubleBufferIndex = 1 - m_doubleBufferIndex; } 78 void swapBuffers() { m_doubleBufferIndex = 1 - m_doubleBufferIndex; }
79 unsigned m_doubleBufferIndex; 79 unsigned m_doubleBufferIndex;
80 unsigned m_doubleBufferIndexForEvent; 80 unsigned m_doubleBufferIndexForEvent;
81 Vector<RefPtr<AudioBuffer> > m_inputBuffers; 81 Vector<RefPtr<AudioBuffer> > m_inputBuffers;
82 Vector<RefPtr<AudioBuffer> > m_outputBuffers; 82 Vector<RefPtr<AudioBuffer> > m_outputBuffers;
83 83
84 size_t m_bufferSize; 84 size_t m_bufferSize;
85 unsigned m_bufferReadWriteIndex; 85 unsigned m_bufferReadWriteIndex;
86 volatile bool m_isRequestOutstanding;
87 86
88 unsigned m_numberOfInputChannels; 87 unsigned m_numberOfInputChannels;
89 unsigned m_numberOfOutputChannels; 88 unsigned m_numberOfOutputChannels;
90 89
91 RefPtr<AudioBus> m_internalInputBus; 90 RefPtr<AudioBus> m_internalInputBus;
91
92 // Synchronize process() with fireProcessEvent().
93 mutable Mutex m_processEventLock;
92 }; 94 };
93 95
94 } // namespace WebCore 96 } // namespace WebCore
95 97
96 #endif // ScriptProcessorNode_h 98 #endif // ScriptProcessorNode_h
OLDNEW
« no previous file with comments | « no previous file | Source/modules/webaudio/ScriptProcessorNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698