Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 212173007: [refactor] Delete unused test code. (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

[refactor] Delete unused test code. Now that all the tests have been moved off using shouldRejectPromiseWithNull() these temporary helpers can be removed. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170263

Patch Set 1 #

Patch Set 2 : Improve logging if tests end with rejection of null #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -96 lines) Patch
M LayoutTests/crypto/resources/common.js View 1 2 chunks +1 line, -96 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eroman
Depends on: https://codereview.chromium.org/215153005
6 years, 9 months ago (2014-03-27 21:52:04 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-27 23:04:37 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-28 03:17:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/212173007/10001
6 years, 9 months ago (2014-03-28 03:17:57 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 04:22:16 UTC) #5
Message was sent while issue was closed.
Change committed as 170263

Powered by Google App Engine
This is Rietveld 408576698