Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 215153005: [refactor] Split up generateKey.html into multiple files, and test errors directly. (Closed)

Created:
6 years, 8 months ago by eroman
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

[refactor] Split up generateKey.html into multiple files, and test errors directly. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170252

Patch Set 1 #

Patch Set 2 : Re-upload with --similarity=20 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -349 lines) Patch
A + LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures.html View 1 1 chunk +16 lines, -20 lines 0 comments Download
A + LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures-expected.txt View 1 1 chunk +8 lines, -10 lines 0 comments Download
A + LayoutTests/crypto/aes-ctr-generateKey-parseAlgorithm-failures.html View 1 1 chunk +11 lines, -23 lines 0 comments Download
A + LayoutTests/crypto/aes-ctr-generateKey-parseAlgorithm-failures-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + LayoutTests/crypto/aes-kw-generateKey-parseAlgorithm-failures.html View 1 1 chunk +11 lines, -23 lines 0 comments Download
A + LayoutTests/crypto/aes-kw-generateKey-parseAlgorithm-failures-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
D LayoutTests/crypto/generateKey.html View 1 chunk +0 lines, -98 lines 0 comments Download
D LayoutTests/crypto/generateKey-expected.txt View 1 chunk +0 lines, -82 lines 0 comments Download
A + LayoutTests/crypto/hmac-generateKey-parseAlgorithm-failures.html View 1 1 chunk +19 lines, -19 lines 0 comments Download
A + LayoutTests/crypto/hmac-generateKey-parseAlgorithm-failures-expected.txt View 1 2 chunks +12 lines, -8 lines 0 comments Download
A + LayoutTests/crypto/rsa-es-generateKey-parseAlgorithm-failures.html View 1 1 chunk +10 lines, -21 lines 0 comments Download
A + LayoutTests/crypto/rsa-es-generateKey-parseAlgorithm-failures-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
A + LayoutTests/crypto/rsa-ssa-generateKey-parseAlgorithm-failures.html View 1 1 chunk +10 lines, -21 lines 0 comments Download
A + LayoutTests/crypto/rsa-ssa-generateKey-parseAlgorithm-failures-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
eroman
6 years, 8 months ago (2014-03-27 21:43:41 UTC) #1
abarth-chromium
lgtm
6 years, 8 months ago (2014-03-27 22:58:59 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 8 months ago (2014-03-27 23:04:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/215153005/20001
6 years, 8 months ago (2014-03-27 23:04:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 00:10:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-03-28 00:10:12 UTC) #6
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 8 months ago (2014-03-28 00:32:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/215153005/20001
6 years, 8 months ago (2014-03-28 00:33:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/215153005/20001
6 years, 8 months ago (2014-03-28 00:34:31 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 02:46:02 UTC) #10
Message was sent while issue was closed.
Change committed as 170252

Powered by Google App Engine
This is Rietveld 408576698