Don't hardcode output directory in findbugs.py

Don't hardcode output directory in findbugs.py

BUG=357190
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260178

[Andrew Hayden (chromium.org), 2014-03-27 22:03:37]

PTAL

[michaelbai, 2014-03-27 22:11:23]

lgtm for findbugs.py, Pls send a PSA once the patch landed?

[Andrew Hayden (chromium.org), 2014-03-27 22:13:05]

+navabi for OWNER of bb_host_steps

[Andrew Hayden (chromium.org), 2014-03-27 22:13:46]

On 2014/03/27 22:11:23, michaelbai wrote:
> lgtm for findbugs.py, Pls send a PSA once the patch landed?

Definitely.

[navabi, 2014-03-27 22:15:14]

lgtm

[Andrew Hayden (chromium.org), 2014-03-28 08:13:25]

So yeah, bots still failing. See comments.

https://codereview.chromium.org/212173006/diff/20001/build/android/buildbot/b...
File build/android/buildbot/bb_host_steps.py (left):

https://codereview.chromium.org/212173006/diff/20001/build/android/buildbot/b...
build/android/buildbot/bb_host_steps.py:85: if options.target == 'Release':
We can't just nuke this, because we need the Release/Debug in the environment.
We have to be smarter, and set it in the environment. We should use:

https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pyli...

To do this. Apparently options.target has what we need. We should bootstrap this
into the environment as far up as possible.

https://codereview.chromium.org/212173006/diff/20001/build/android/pylib/util...
File build/android/pylib/utils/findbugs.py (right):

https://codereview.chromium.org/212173006/diff/20001/build/android/pylib/util...
build/android/pylib/utils/findbugs.py:208: dest='release_build',
This needs to be killed off as well

[Andrew Hayden (chromium.org), 2014-03-28 08:38:03]

Speculative fix for the bots, which I've kicked off again. Hopefully this will
take care of it.

[navabi, 2014-03-28 10:04:41]

lgtm

[navabi1, 2014-03-28 10:07:13]

lgtm

[Andrew Hayden (chromium.org), 2014-03-28 10:16:25]

The CQ bit was checked by andrewhayden@chromium.org

[commit-bot: I haz the power, 2014-03-28 10:16:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/212173006/30001

[commit-bot: I haz the power, 2014-03-28 10:58:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 10:58:33]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Andrew Hayden (chromium.org), 2014-03-28 11:08:51]

Thanks to an anonymous individual for suggesting the "fix". I know he/she will
not want to be named, for the shame of having to know how to satisfy findbugs
here :)

Anyhow, this passes the linter and findbugs now, so let's try the CQ again.

[Andrew Hayden (chromium.org), 2014-03-28 11:09:13]

The CQ bit was checked by andrewhayden@chromium.org

[commit-bot: I haz the power, 2014-03-28 11:10:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/212173006/50001

[commit-bot: I haz the power, 2014-03-28 17:11:43]

Change committed as 260178