Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: build/android/buildbot/bb_host_steps.py

Issue 212173006: Don't hardcode output directory in findbugs.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-duration
Patch Set: "Fix" findbugs "error" Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/android/pylib/utils/findbugs.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import os 6 import os
7 import sys 7 import sys
8 8
9 import bb_utils 9 import bb_utils
10 import bb_annotations 10 import bb_annotations
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 73
74 74
75 def ExtractBuild(options): 75 def ExtractBuild(options):
76 bb_annotations.PrintNamedStep('extract_build') 76 bb_annotations.PrintNamedStep('extract_build')
77 RunCmd([os.path.join(SLAVE_SCRIPTS_DIR, 'extract_build.py')] 77 RunCmd([os.path.join(SLAVE_SCRIPTS_DIR, 'extract_build.py')]
78 + bb_utils.EncodeProperties(options), 78 + bb_utils.EncodeProperties(options),
79 warning_code=1, cwd=DIR_BUILD_ROOT) 79 warning_code=1, cwd=DIR_BUILD_ROOT)
80 80
81 81
82 def FindBugs(options): 82 def FindBugs(options):
83 _ = options # keeps the linter and findbugs happy, parameter is not used
83 bb_annotations.PrintNamedStep('findbugs') 84 bb_annotations.PrintNamedStep('findbugs')
84 build_type = [] 85 RunCmd([SrcPath('build', 'android', 'findbugs_diff.py')])
85 if options.target == 'Release':
86 build_type = ['--release-build']
87 RunCmd([SrcPath('build', 'android', 'findbugs_diff.py')] + build_type)
88 RunCmd([SrcPath( 86 RunCmd([SrcPath(
89 'tools', 'android', 'findbugs_plugin', 'test', 87 'tools', 'android', 'findbugs_plugin', 'test',
90 'run_findbugs_plugin_tests.py')] + build_type) 88 'run_findbugs_plugin_tests.py')])
91 89
92 90
93 def BisectPerfRegression(options): 91 def BisectPerfRegression(options):
94 args = [] 92 args = []
95 if options.extra_src: 93 if options.extra_src:
96 args = ['--extra_src', options.extra_src] 94 args = ['--extra_src', options.extra_src]
97 RunCmd([SrcPath('tools', 'prepare-bisect-perf-regression.py'), 95 RunCmd([SrcPath('tools', 'prepare-bisect-perf-regression.py'),
98 '-w', os.path.join(constants.DIR_SOURCE_ROOT, os.pardir)]) 96 '-w', os.path.join(constants.DIR_SOURCE_ROOT, os.pardir)])
99 RunCmd([SrcPath('tools', 'run-bisect-perf-regression.py'), 97 RunCmd([SrcPath('tools', 'run-bisect-perf-regression.py'),
100 '-w', os.path.join(constants.DIR_SOURCE_ROOT, os.pardir)] + args) 98 '-w', os.path.join(constants.DIR_SOURCE_ROOT, os.pardir)] + args)
(...skipping 26 matching lines...) Expand all
127 125
128 def main(argv): 126 def main(argv):
129 parser = GetHostStepsOptParser() 127 parser = GetHostStepsOptParser()
130 options, args = parser.parse_args(argv[1:]) 128 options, args = parser.parse_args(argv[1:])
131 if args: 129 if args:
132 return sys.exit('Unused args %s' % args) 130 return sys.exit('Unused args %s' % args)
133 131
134 setattr(options, 'target', options.factory_properties.get('target', 'Debug')) 132 setattr(options, 'target', options.factory_properties.get('target', 'Debug'))
135 setattr(options, 'extra_src', 133 setattr(options, 'extra_src',
136 options.factory_properties.get('extra_src', '')) 134 options.factory_properties.get('extra_src', ''))
135 constants.SetBuildType(options.target)
137 136
138 if options.steps: 137 if options.steps:
139 bb_utils.RunSteps(options.steps.split(','), GetHostStepCmds(), options) 138 bb_utils.RunSteps(options.steps.split(','), GetHostStepCmds(), options)
140 139
141 140
142 if __name__ == '__main__': 141 if __name__ == '__main__':
143 sys.exit(main(sys.argv)) 142 sys.exit(main(sys.argv))
OLDNEW
« no previous file with comments | « no previous file | build/android/pylib/utils/findbugs.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698