Don't store empty values for autofill

This CL ensures we don't store empty values in the autofill form DB.
Also it applies a clean-up to remove any empty values previously stored in the DB.

BUG=6111
TEST=Submit a form and leave some fields empty. Come back to that form, click on a field that was empty. No autofill popup should show up (or if one show up, it should not contains empty values).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9570

[jcampan, 2009-02-10 18:59:12]

I briefly took my mind of layout tests and fixed this.

[sky, 2009-02-10 19:24:25]

http://codereview.chromium.org/21217/diff/22/1014
File chrome/browser/autofill_manager.cc (right):

http://codereview.chromium.org/21217/diff/22/1014#newcode124
Line 124: void AutofillManager::ClearEmptyEntriesInWebDatabase() {
I would recommend have a version check in the WebDB. It should result in less
code and is typically how we do this sort of migration.

http://codereview.chromium.org/21217/diff/22/1017
File chrome/browser/webdata/web_database.cc (right):

http://codereview.chromium.org/21217/diff/22/1017#newcode1143
Line 1143: SQLStatement s2;
Have you considered making RemoveFormElementForTimeRange take a null first date,
rather than having similar code in both places?

[jcampan, 2009-02-10 20:29:55]

http://codereview.chromium.org/21217/diff/22/1014
File chrome/browser/autofill_manager.cc (right):

http://codereview.chromium.org/21217/diff/22/1014#newcode124
Line 124: void AutofillManager::ClearEmptyEntriesInWebDatabase() {
On 2009/02/10 19:24:25, sky wrote:
> I would recommend have a version check in the WebDB. It should result in less
> code and is typically how we do this sort of migration.
Good suggestion.
Most of the previous code is now gone.

http://codereview.chromium.org/21217/diff/22/1017
File chrome/browser/webdata/web_database.cc (right):

http://codereview.chromium.org/21217/diff/22/1017#newcode1143
Line 1143: SQLStatement s2;
On 2009/02/10 19:24:25, sky wrote:
> Have you considered making RemoveFormElementForTimeRange take a null first
date,
> rather than having similar code in both places?

Done.

[sky, 2009-02-10 21:06:00]

http://codereview.chromium.org/21217/diff/28/1040
File webkit/glue/autofill_form.cc (right):

http://codereview.chromium.org/21217/diff/28/1040#newcode72
Line 72: result->elements.push_back(AutofillForm::Element(name, value));
Does the matching side trim whitespace too? If not, do you really want to store
the trimmed name?

[jcampan, 2009-02-10 21:24:55]

http://codereview.chromium.org/21217/diff/28/1040
File webkit/glue/autofill_form.cc (right):

http://codereview.chromium.org/21217/diff/28/1040#newcode72
Line 72: result->elements.push_back(AutofillForm::Element(name, value));
On 2009/02/10 21:06:00, sky wrote:
> Does the matching side trim whitespace too? If not, do you really want to
store
> the trimmed name?
You are right, we probably don't want to store the trimmed name.

[sky, 2009-02-10 21:34:36]

LGTM