Don't store empty values for autofill

chrome/browser/webdata/web_database_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/time.h"
 #include "base/values.h"
 #include "chrome/browser/search_engines/template_url.h"
@@ skipping 446 matching lines @@
   // Removing all elements since the beginning of this function should remove
   // everything from the database.
   EXPECT_TRUE(db.RemoveFormElementsAddedBetween(t1, Time()));
 
   EXPECT_TRUE(db.GetIDAndCountOfFormElement(
       AutofillForm::Element(L"Name", L"Clark Kent"), &pair_id, &count));
   EXPECT_EQ(0, count);
 
   EXPECT_TRUE(db.GetFormValuesForElementName(L"Name", L"", &v, 6));
   EXPECT_EQ(0U, v.size());
+
+  // Now add some values with empty strings.
+  const std::wstring kValue = L"  toto   ";
+  EXPECT_TRUE(db.AddAutofillFormElement(AutofillForm::Element(L"blank", L"")));
+  EXPECT_TRUE(db.AddAutofillFormElement(AutofillForm::Element(L"blank",
+                                                              L" ")));
+  EXPECT_TRUE(db.AddAutofillFormElement(AutofillForm::Element(L"blank",
+                                                              L"      ")));
+  EXPECT_TRUE(db.AddAutofillFormElement(AutofillForm::Element(L"blank",
+                                                              kValue)));
+
+  // They should be stored normally as the DB layer does not check for empty
+  // values.
+  v.clear();
+  EXPECT_TRUE(db.GetFormValuesForElementName(L"blank", L"", &v, 10));
+  EXPECT_EQ(4U, v.size());
+
+  // Now we'll check that ClearAutofillEmptyValueElements() works as expected.
+  db.ClearAutofillEmptyValueElements();
+
+  v.clear();
+  EXPECT_TRUE(db.GetFormValuesForElementName(L"blank", L"", &v, 10));
+  ASSERT_EQ(1U, v.size());
+
+  EXPECT_EQ(kValue, v[0]);
 }
 
 static bool AddTimestampedLogin(WebDatabase* db, std::string url,
                                 std::wstring unique_string, const Time& time) {
   // Example password form.
   PasswordForm form;
   form.origin = GURL(url + std::string("/LoginAuth"));
   form.username_element = unique_string.c_str();
   form.username_value = unique_string.c_str();
   form.password_element = unique_string.c_str();
@@ skipping 168 matching lines @@
     ASSERT_EQ(32, images[1].width());
     ASSERT_EQ(32, images[1].height());
   } else {
     ASSERT_EQ(32, images[0].width());
     ASSERT_EQ(32, images[0].height());
     ASSERT_EQ(16, images[1].width());
     ASSERT_EQ(16, images[1].height());
   }
 }