Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2121663002: Add IMMEDIATE_CRASH to measure how much V8 APIs return empty MaybeLocal handles

Created:
4 years, 5 months ago by haraken
Modified:
4 years, 5 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IMMEDIATE_CRASH to measure how much V8 APIs return empty MaybeLocal handles Thanks to nhiroki's work, isolate->TerminateExecution was removed from common paths of worker shutdown. Hence, it should be super rare that V8 APIs return empty MaybeLocal handles. This CL adds IMMEDIATE_CRASH to measure how rare it is in the real world. BUG=625512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h View 3 chunks +13 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/v8.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
haraken
PTAL
4 years, 5 months ago (2016-07-04 01:56:16 UTC) #2
haraken
4 years, 5 months ago (2016-07-04 05:28:32 UTC) #3
It seems a lot of tests are failing. Looking.

Powered by Google App Engine
This is Rietveld 408576698