Stop using the mediaFullscreenRequiresUserGesture setting

Stop using the mediaFullscreenRequiresUserGesture setting

"Make mediaPlayerRequestFullscreen() user gesture bypass explicit"
(Blink r170080) makes the setting redundant.

BUG=355439
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260363

[philipj_slow, 2014-03-26 07:41:49]

Patch 2/3, depends on https://codereview.chromium.org/209693003/

[acolwell GONE FROM CHROMIUM, 2014-03-26 17:47:30]

lgtm

https://codereview.chromium.org/212133003/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host_impl.cc (left):

https://codereview.chromium.org/212133003/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host_impl.cc:454:
switches::kDisableGestureRequirementForMediaFullscreen);
Is the plan to remove the kDisableGestureRequirementForMediaFullscreen decl in a
follow-up CL? It seems like the only other reference is in
browser_media_player_manager.cc

[philipj_slow, 2014-03-26 17:58:04]

https://codereview.chromium.org/212133003/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host_impl.cc (left):

https://codereview.chromium.org/212133003/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host_impl.cc:454:
switches::kDisableGestureRequirementForMediaFullscreen);
On 2014/03/26 17:47:31, acolwell wrote:
> Is the plan to remove the kDisableGestureRequirementForMediaFullscreen decl in
a
> follow-up CL? It seems like the only other reference is in
> browser_media_player_manager.cc

So this is a bit ugly, but it's still used in
BrowserMediaPlayerManager::OnProtectedSurfaceRequested(), it just has nothing to
do with the Blink setting any longer.

qinmin, what do you think should be done with that after this CL has landed? If
playback just doesn't work without fullscreen it seems to me like the
MediaPlayerMsg_RequestFullscreen should be unconditional, but I don't know the
details here.

If the flag should stay then a better name wouldn't hurt, but whichever product
sets the flag would have to be kept in sync, and that code is not available to
me.

[philipj_slow, 2014-03-27 10:45:07]

Since I got the LGTM I'm going to land this now (Blink roll has happened) but of
course I'll read any further comments and perform any cleanup requested around
kDisableGestureRequirementForMediaFullscreen in future CLs.

[philipj_slow, 2014-03-27 10:45:12]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-03-27 10:45:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/212133003/1

[commit-bot: I haz the power, 2014-03-27 11:16:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 11:16:43]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[philipj_slow, 2014-03-27 11:32:08]

Oops, missing OWNERS review. darin, jochen, can you PTAL?

[jochen (gone - plz use gerrit), 2014-03-27 14:21:31]

lgtm

[philipj_slow, 2014-03-28 06:51:37]

dcheng, can you review content/public/common/common_param_traits_macros.h?

kinuko, can you review webkit/common/webpreferences.*?

[kinuko, 2014-03-28 12:15:50]

On 2014/03/28 06:51:37, philipj wrote:
> dcheng, can you review content/public/common/common_param_traits_macros.h?
> 
> kinuko, can you review webkit/common/webpreferences.*?

webkit/common lgtm

[dcheng, 2014-03-28 20:25:47]

lgtm

[philipj_slow, 2014-03-29 03:21:35]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-03-29 03:22:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/212133003/1

[commit-bot: I haz the power, 2014-03-29 05:12:19]

Change committed as 260363