Stop using the mediaFullscreenRequiresUserGesture setting

content/browser/renderer_host/render_view_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host_impl.h"
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 432 matching lines @@
       command_line.HasSwitch(switches::kEnableExperimentalWebSocket);
   if (command_line.HasSwitch(cc::switches::kEnablePinchVirtualViewport)) {
     prefs.pinch_virtual_viewport_enabled = true;
     prefs.pinch_overlay_scrollbar_thickness = 10;
   }
   prefs.use_solid_color_scrollbars = ui::IsOverlayScrollbarEnabled();
 
 #if defined(OS_ANDROID)
   prefs.user_gesture_required_for_media_playback = !command_line.HasSwitch(
       switches::kDisableGestureRequirementForMediaPlayback);
-  prefs.user_gesture_required_for_media_fullscreen = !command_line.HasSwitch(
-      switches::kDisableGestureRequirementForMediaFullscreen);

[acolwell GONE FROM CHROMIUM, 2014/03/26 17:47:31]

Is the plan to remove the kDisableGestureRequirementForMediaFullscreen decl in a
follow-up CL? It seems like the only other reference is in
browser_media_player_manager.cc

[philipj_slow, 2014/03/26 17:58:04]

So this is a bit ugly, but it's still used in
BrowserMediaPlayerManager::OnProtectedSurfaceRequested(), it just has nothing to
do with the Blink setting any longer.

qinmin, what do you think should be done with that after this CL has landed? If
playback just doesn't work without fullscreen it seems to me like the
MediaPlayerMsg_RequestFullscreen should be unconditional, but I don't know the
details here.

If the flag should stay then a better name wouldn't hurt, but whichever product
sets the flag would have to be kept in sync, and that code is not available to
me.

 #endif
 
   prefs.touch_enabled = ui::AreTouchEventsEnabled();
   prefs.device_supports_touch = prefs.touch_enabled &&
       ui::IsTouchDevicePresent();
 #if defined(OS_ANDROID)
   prefs.device_supports_mouse = false;
 #endif
 
   prefs.pointer_events_max_touch_points = ui::MaxTouchPoints();
@@ skipping 1463 matching lines @@
   return true;
 }
 
 void RenderViewHostImpl::AttachToFrameTree() {
   FrameTree* frame_tree = delegate_->GetFrameTree();
 
   frame_tree->ResetForMainFrameSwap();
 }
 
 }  // namespace content