third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp - Issue 2121313003: [Editing][DOM][CodeHealth] Make Node::isContentEditable and Node::isRichEditable global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp

Issue 2121313003: [Editing][DOM][CodeHealth] Make Node::isContentEditable and Node::isRichEditable global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp

index bbfed419b48b31164a6d990daa8a728f74024a02..ca03d58e23a7e9440fe0f99bf053d505be735a16 100644

--- a/third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp

@@ -46,7 +46,7 @@ void DeleteFromTextNodeCommand::doApply(EditingState*)

{

DCHECK(m_node);

- if (!m_node->isContentEditable())

+ if (!isContentEditable(*m_node))

return;

TrackExceptionState exceptionState;