Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp

Issue 2121313003: [Editing][DOM][CodeHealth] Make Node::isContentEditable and Node::isRichEditable global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 28 matching lines...) Expand all
39 { 39 {
40 DCHECK(m_node); 40 DCHECK(m_node);
41 DCHECK_LE(m_offset, m_node->length()); 41 DCHECK_LE(m_offset, m_node->length());
42 DCHECK_LE(m_offset + m_count, m_node->length()); 42 DCHECK_LE(m_offset + m_count, m_node->length());
43 } 43 }
44 44
45 void DeleteFromTextNodeCommand::doApply(EditingState*) 45 void DeleteFromTextNodeCommand::doApply(EditingState*)
46 { 46 {
47 DCHECK(m_node); 47 DCHECK(m_node);
48 48
49 if (!m_node->isContentEditable()) 49 if (!isContentEditable(*m_node))
50 return; 50 return;
51 51
52 TrackExceptionState exceptionState; 52 TrackExceptionState exceptionState;
53 m_text = m_node->substringData(m_offset, m_count, exceptionState); 53 m_text = m_node->substringData(m_offset, m_count, exceptionState);
54 if (exceptionState.hadException()) 54 if (exceptionState.hadException())
55 return; 55 return;
56 56
57 m_node->deleteData(m_offset, m_count, exceptionState); 57 m_node->deleteData(m_offset, m_count, exceptionState);
58 m_node->document().updateStyleAndLayout(); 58 m_node->document().updateStyleAndLayout();
59 } 59 }
60 60
61 void DeleteFromTextNodeCommand::doUnapply() 61 void DeleteFromTextNodeCommand::doUnapply()
62 { 62 {
63 DCHECK(m_node); 63 DCHECK(m_node);
64 64
65 if (!hasEditableStyle(*m_node)) 65 if (!hasEditableStyle(*m_node))
66 return; 66 return;
67 67
68 m_node->insertData(m_offset, m_text, IGNORE_EXCEPTION); 68 m_node->insertData(m_offset, m_text, IGNORE_EXCEPTION);
69 m_node->document().updateStyleAndLayout(); 69 m_node->document().updateStyleAndLayout();
70 } 70 }
71 71
72 DEFINE_TRACE(DeleteFromTextNodeCommand) 72 DEFINE_TRACE(DeleteFromTextNodeCommand)
73 { 73 {
74 visitor->trace(m_node); 74 visitor->trace(m_node);
75 SimpleEditCommand::trace(visitor); 75 SimpleEditCommand::trace(visitor);
76 } 76 }
77 77
78 } // namespace blink 78 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698