Index: third_party/WebKit/Source/modules/sensor/SensorReadingEvent.h |
diff --git a/third_party/WebKit/Source/modules/sensor/SensorReadingEvent.h b/third_party/WebKit/Source/modules/sensor/SensorReadingEvent.h |
index d2c1b44158baf1e37cf898bb9c05f91ac1e3d498..c0799b5d9e5a7b3abe2aee9e8e036e0464dbf890 100644 |
--- a/third_party/WebKit/Source/modules/sensor/SensorReadingEvent.h |
+++ b/third_party/WebKit/Source/modules/sensor/SensorReadingEvent.h |
@@ -16,12 +16,12 @@ class SensorReadingEvent : public Event { |
DEFINE_WRAPPERTYPEINFO(); |
public: |
- static SensorReadingEvent* create(const AtomicString& eventType) |
+ static SensorReadingEvent* create() |
{ |
- return new SensorReadingEvent(eventType); |
+ return new SensorReadingEvent; |
} |
- static SensorReadingEvent* create(const AtomicString& eventType, SensorReading& reading) |
+ static SensorReadingEvent* create(const AtomicString& eventType, SensorReading* reading) |
timvolodine
2016/08/25 17:52:33
should this also be a const SensorReading&?
Mikhail
2016/08/26 16:42:42
it might be 'SensorReading&' to give a hint that r
|
{ |
return new SensorReadingEvent(eventType, reading); |
} |
@@ -33,8 +33,8 @@ public: |
~SensorReadingEvent() override; |
- // TODO(riju): crbug.com/614797 . |
- SensorReading* reading() const { return m_reading.get(); } |
+ const SensorReading* reading() const { return m_reading.get(); } |
+ SensorReading* reading() { return m_reading.get(); } |
timvolodine
2016/08/25 17:52:33
is this method needed?
Mikhail
2016/08/26 16:42:42
Both are used by V8 bindings..
|
const AtomicString& interfaceName() const override; |
DECLARE_VIRTUAL_TRACE(); |
@@ -43,8 +43,8 @@ protected: |
Member<SensorReading> m_reading; |
private: |
- explicit SensorReadingEvent(const AtomicString& eventType); |
- SensorReadingEvent(const AtomicString& eventType, SensorReading&); |
+ SensorReadingEvent(); |
timvolodine
2016/08/25 17:52:33
needed?
Mikhail
2016/08/26 16:42:42
actually not :) thanks!
|
+ SensorReadingEvent(const AtomicString& eventType, SensorReading*); |
SensorReadingEvent(const AtomicString& eventType, const SensorReadingEventInit& initializer); |
}; |