[sensors] Generic Sensors Framework blink side

third_party/WebKit/Source/modules/sensor/SensorReadingEvent.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SensorReadingEvent_h
 #define SensorReadingEvent_h
 
 #include "modules/EventModules.h"
 #include "modules/sensor/SensorReading.h"
 #include "modules/sensor/SensorReadingEventInit.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
 class SensorReadingEvent : public Event {
     DEFINE_WRAPPERTYPEINFO();
 
 public:
-    static SensorReadingEvent* create(const AtomicString& eventType)
+    static SensorReadingEvent* create()
     {
-        return new SensorReadingEvent(eventType);
+        return new SensorReadingEvent;
     }
 
-    static SensorReadingEvent* create(const AtomicString& eventType, SensorReading& reading)
+    static SensorReadingEvent* create(const AtomicString& eventType, SensorReading* reading)

[timvolodine, 2016/08/25 17:52:33]

should this also be a const SensorReading&?

[Mikhail, 2016/08/26 16:42:42]

it might be 'SensorReading&' to give a hint that reading must not be null but
since reading is obtained from Sensor as pointer and further stored and returned
from this class as pointer too, I would just add DCHECK(reading) to the
constructors.

     {
         return new SensorReadingEvent(eventType, reading);
     }
 
     static SensorReadingEvent* create(const AtomicString& eventType, const SensorReadingEventInit& initializer)
     {
         return new SensorReadingEvent(eventType, initializer);
     }
 
     ~SensorReadingEvent() override;
 
-    // TODO(riju): crbug.com/614797 .
-    SensorReading* reading() const { return m_reading.get(); }
+    const SensorReading* reading() const { return m_reading.get(); }
+    SensorReading* reading() { return m_reading.get(); }

[timvolodine, 2016/08/25 17:52:33]

is this method needed?

[Mikhail, 2016/08/26 16:42:42]

Both are used by V8 bindings..

     const AtomicString& interfaceName() const override;
 
     DECLARE_VIRTUAL_TRACE();
 
 protected:
     Member<SensorReading> m_reading;
 
 private:
-    explicit SensorReadingEvent(const AtomicString& eventType);
-    SensorReadingEvent(const AtomicString& eventType, SensorReading&);
+    SensorReadingEvent();

[timvolodine, 2016/08/25 17:52:33]

needed?

[Mikhail, 2016/08/26 16:42:42]

actually not :) thanks!

+    SensorReadingEvent(const AtomicString& eventType, SensorReading*);
     SensorReadingEvent(const AtomicString& eventType, const SensorReadingEventInit& initializer);
 
 };
 
 DEFINE_TYPE_CASTS(SensorReadingEvent, Event, event, event->interfaceName() == EventNames::SensorReadingEvent, event.interfaceName() == EventNames::SensorReadingEvent);
 
 } // namepsace blink
 
 #endif // SensorReadingEvent_h