Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2121293003: Adds a QuicUtil::HexDump method that provides better debug output of binary data. (Closed)

Created:
4 years, 5 months ago by rjshade
Modified:
4 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@126089643
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds a QuicUtil::HexDump method that provides better debug output of binary data. Example output: 48 65 6c 6c 6f 2c 20 51 55 49 43 21 20 54 68 69 |Hello, QUIC! Thi| 73 20 73 74 72 69 6e 67 20 73 68 6f 75 6c 64 20 |s string should | 62 65 20 6c 6f 6e 67 20 65 6e 6f 75 67 68 20 74 |be long enough t| 6f 20 73 70 61 6e 20 6d 75 6c 74 69 70 6c 65 20 |o span multiple | 6c 69 6e 65 73 20 6f 66 20 6f 75 74 70 75 74 2e |lines of output.| 01 02 03 04 |.... | Merge internal change: 126091835 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Replace use of ascii_isprint #

Patch Set 3 : Use uppercase hex characters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -25 lines) Patch
M net/quic/quic_utils.h View 1 chunk +6 lines, -3 lines 0 comments Download
M net/quic/quic_utils.cc View 1 1 chunk +31 lines, -8 lines 0 comments Download
M net/quic/quic_utils_test.cc View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
rjshade
4 years, 5 months ago (2016-07-06 18:35:55 UTC) #1
Ryan Hamilton
4 years, 5 months ago (2016-07-06 19:22:32 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698