Adds a QuicUtil::HexDump method that provides better debug output of binary data.

net/quic/quic_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_utils.h"
 
 #include <ctype.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 551 matching lines @@
     return "";
   std::vector<uint8_t> v;
   if (!base::HexStringToBytes(data.as_string(), &v))
     return "";
   string out;
   if (!v.empty())
     out.assign(reinterpret_cast<const char*>(&v[0]), v.size());
   return out;
 }
 
-string QuicUtils::BinaryToAscii(StringPiece binary) {
+string QuicUtils::HexDump(StringPiece binary_input) {
   string out = "";
-  for (const unsigned char c : binary) {
-    // Leading space.
-    out += " ";
-    if (isprint(c)) {
-      out += c;
-    } else {
-      out += '.';
+  const int kBytesPerRow = 16;
+  const int size = binary_input.size();
+  for (int i = 0; i < size;) {
+    // Print one row of hex.
+    for (int j = i; j < i + kBytesPerRow; ++j) {
+      if (j < size) {
+        out += HexEncode(string(1, binary_input[j]));
+      } else {
+        out += "  ";
+      }
+      out += " ";
     }
+    out += " |";
+
+    // Print one row of ascii.
+    for (int j = i; j < i + kBytesPerRow; ++j) {
+      if (j < size) {
+        char c = binary_input[j];
+        bool is_printable = (c >= 32 && c < 127);
+        if (!is_printable) {
+          // Non-printable characters are replaced with '.'.
+          c = '.';
+        }
+        out += string(1, c);
+      } else {
+        out += " ";
+      }
+    }
+
+    out += "|\n";
+    i += kBytesPerRow;
   }
   return out;
 }
 
 }  // namespace net