Embed address normalization rewriting rules.

Embed address normalization rewriting rules.

This CL adds a table of string rewrite rules, keyed by country
code, to aid in address normalization when comparing autofill
profiles.

The rules for each country code are stored as static constant
string tables and compiled to regular expression replacement
params on first use, and subsequently cached.

R=mathp@chromium.org, sebsg@chromium.org
BUG=618095
Committed: https://crrev.com/0d2a71a993405545d9a735e5a8d5807815ee24c2
Cr-Commit-Position: refs/heads/master@{#404158}

[Mathieu, 2016-07-06 17:50:46]

lgtm, can we confirm that even though it's compile on use for a given region,
the ProfileComparator is not in the startup critical path?

https://codereview.chromium.org/2121253002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/address_rewriter.cc (right):

https://codereview.chromium.org/2121253002/diff/20001/components/autofill/cor...
components/autofill/core/browser/address_rewriter.cc:46: // Return the sigleton
instance of the cache.
nit:singleton

https://codereview.chromium.org/2121253002/diff/20001/components/autofill/cor...
components/autofill/core/browser/address_rewriter.cc:55: // that the returned
data is const and can be concurrently accesses, just
*accessed

https://codereview.chromium.org/2121253002/diff/20001/components/autofill/cor...
components/autofill/core/browser/address_rewriter.cc:104: const std::string
region = UTF16ToUTF8(base::i18n::ToUpper(country_code));
base::UTF16ToUTF8 ?

https://codereview.chromium.org/2121253002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/address_rewriter.h (right):

https://codereview.chromium.org/2121253002/diff/20001/components/autofill/cor...
components/autofill/core/browser/address_rewriter.h:39: // The structure used to
statically defined a set of rules for a region.
nit: define

[Roger McFarlane (Chromium), 2016-07-06 21:28:02]

Patchset #3 (id:40001) has been deleted

[Roger McFarlane (Chromium), 2016-07-06 21:28:18]

Patchset #3 (id:60001) has been deleted

[Roger McFarlane (Chromium), 2016-07-06 21:28:38]

Thanks!

Seb, do you have any comments?

https://codereview.chromium.org/2121253002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/address_rewriter.cc (right):

https://codereview.chromium.org/2121253002/diff/20001/components/autofill/cor...
components/autofill/core/browser/address_rewriter.cc:46: // Return the sigleton
instance of the cache.
On 2016/07/06 17:50:46, Mathieu Perreault wrote:
> nit:singleton

Done.

https://codereview.chromium.org/2121253002/diff/20001/components/autofill/cor...
components/autofill/core/browser/address_rewriter.cc:55: // that the returned
data is const and can be concurrently accesses, just
On 2016/07/06 17:50:46, Mathieu Perreault wrote:
> *accessed

Done.

https://codereview.chromium.org/2121253002/diff/20001/components/autofill/cor...
components/autofill/core/browser/address_rewriter.cc:104: const std::string
region = UTF16ToUTF8(base::i18n::ToUpper(country_code));
On 2016/07/06 17:50:46, Mathieu Perreault wrote:
> base::UTF16ToUTF8 ?

Done.

https://codereview.chromium.org/2121253002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/address_rewriter.h (right):

https://codereview.chromium.org/2121253002/diff/20001/components/autofill/cor...
components/autofill/core/browser/address_rewriter.h:39: // The structure used to
statically defined a set of rules for a region.
On 2016/07/06 17:50:46, Mathieu Perreault wrote:
> nit: define

Done.

[sebsg, 2016-07-07 09:56:12]

This lgtm, great work!

[Roger McFarlane (Chromium), 2016-07-07 14:29:06]

The CQ bit was checked by rogerm@chromium.org

[Roger McFarlane (Chromium), 2016-07-07 14:29:06]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2121253002/#ps80001
(title: "address review comments")

[commit-bot: I haz the power, 2016-07-07 14:29:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 16:23:54]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-07-07 16:24:02]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 16:25:21]

Description was changed from

==========
Embed address normalization rewriting rules.

This CL adds a table of string rewrite rules, keyed by country
code, to aid in address normalization when comparing autofill
profiles.

The rules for each country code are stored as static constant
string tables and compiled to regular expression replacement
params on first use, and subsequently cached.

R=mathp@chromium.org, sebsg@chromium.org
BUG=618095
==========

to

==========
Embed address normalization rewriting rules.

This CL adds a table of string rewrite rules, keyed by country
code, to aid in address normalization when comparing autofill
profiles.

The rules for each country code are stored as static constant
string tables and compiled to regular expression replacement
params on first use, and subsequently cached.

R=mathp@chromium.org, sebsg@chromium.org
BUG=618095

Committed: https://crrev.com/0d2a71a993405545d9a735e5a8d5807815ee24c2
Cr-Commit-Position: refs/heads/master@{#404158}
==========

[commit-bot: I haz the power, 2016-07-07 16:25:22]

Patchset 3 (id:??) landed as
https://crrev.com/0d2a71a993405545d9a735e5a8d5807815ee24c2
Cr-Commit-Position: refs/heads/master@{#404158}

[Mathieu, 2016-07-07 19:47:24]

A revert of this CL (patchset #3 id:80001) has been created in
https://codereview.chromium.org/2125383002/ by mathp@chromium.org.

The reason for reverting is: Some merging logic could trigger DCHECK on debug
builds. Will reland with fix..

[Roger McFarlane (Chromium), 2016-07-08 14:36:17]

Moved to https://codereview.chromium.org/2137533002