Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2121163003: Remove chrome/browser/services/fake_signin_manager (Closed)

Created:
4 years, 5 months ago by kbalazs
Modified:
4 years, 5 months ago
Reviewers:
Peter Beverloo, dimich
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove chrome/browser/services/fake_signin_manager It was dead code after previous refactorings. BUG=519411 Committed: https://crrev.com/8dfa7bcdd60f72776551ec89c8d4eb5949e0f622 Cr-Commit-Position: refs/heads/master@{#404198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -130 lines) Patch
D chrome/browser/services/gcm/fake_signin_manager.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/services/gcm/fake_signin_manager.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
kbalazs
4 years, 5 months ago (2016-07-05 21:14:38 UTC) #2
Peter Beverloo
lgtm
4 years, 5 months ago (2016-07-07 17:08:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121163003/1
4 years, 5 months ago (2016-07-07 17:10:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 19:01:12 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 19:04:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8dfa7bcdd60f72776551ec89c8d4eb5949e0f622
Cr-Commit-Position: refs/heads/master@{#404198}

Powered by Google App Engine
This is Rietveld 408576698