Move FakeGCMProfileService to components

Move FakeGCMProfileService to components

It has no chrome dependencies. This is part of the effort to componentize
gcm code in chrome as much as possible.

BUG=519411

[kbalazs, 2016-07-06 22:24:03]

@peter/@dimich: gcm
@jam: rs the rest please

[kbalazs, 2016-07-06 23:43:47]

b.kelemen@samsung.com changed reviewers:
+ dimich@chromium.org, jam@chromium.org, peter@chromium.org

[kbalazs, 2016-07-06 23:43:47]

@dimich/@peter: gcm
@jam: rs the rest please

[Peter Beverloo, 2016-07-07 17:07:36]

I'm OK with this, but please address the two comments below :).

https://codereview.chromium.org/2122603007/diff/60001/components/gcm_driver.gypi
File components/gcm_driver.gypi (right):

https://codereview.chromium.org/2122603007/diff/60001/components/gcm_driver.g...
components/gcm_driver.gypi:49: 'gcm_driver/fake_gcm_profile_service.h',
You'll only want these in the test_support target (as you do on line :156),
adding them here would include it in production builds.

https://codereview.chromium.org/2122603007/diff/60001/components/gcm_driver/B...
File components/gcm_driver/BUILD.gn (right):

https://codereview.chromium.org/2122603007/diff/60001/components/gcm_driver/B...
components/gcm_driver/BUILD.gn:156: "gcm_profile_service_unittest.cc",
This file isn't being moved.

[kbalazs, 2016-07-07 21:06:26]

On 2016/07/07 17:07:36, Peter Beverloo wrote:
> I'm OK with this, but please address the two comments below :).
> 
>
https://codereview.chromium.org/2122603007/diff/60001/components/gcm_driver.gypi
> File components/gcm_driver.gypi (right):
> 
>
https://codereview.chromium.org/2122603007/diff/60001/components/gcm_driver.g...
> components/gcm_driver.gypi:49: 'gcm_driver/fake_gcm_profile_service.h',
> You'll only want these in the test_support target (as you do on line :156),
> adding them here would include it in production builds.

Done

> 
>
https://codereview.chromium.org/2122603007/diff/60001/components/gcm_driver/B...
> File components/gcm_driver/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2122603007/diff/60001/components/gcm_driver/B...
> components/gcm_driver/BUILD.gn:156: "gcm_profile_service_unittest.cc",
> This file isn't being moved.

Done

[Peter Beverloo, 2016-07-08 14:00:01]

Thanks :) SGTM after the compile error is fixed, I'll stamp whenever you get to
that!

https://codereview.chromium.org/2122603007/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/net/wake_on_wifi_manager_unittest.cc (right):

https://codereview.chromium.org/2122603007/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/net/wake_on_wifi_manager_unittest.cc:30: &profile_,
&BuildFakeGCMProfileService);
nit: not your change, but you could remove lines 21-24 and use
gcm::FakeGCMProfileService::Build immediately here- it's meant for that purpose.

https://codereview.chromium.org/2122603007/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/api/instance_id/instance_id_apitest.cc (right):

https://codereview.chromium.org/2122603007/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/api/instance_id/instance_id_apitest.cc:31: new
gcm::FakeGCMProfileService(Profile::FromBrowserContext(context)));
This won't compile because you removed the argument from the constructor.

https://codereview.chromium.org/2122603007/diff/100001/chrome/browser/push_me...
File chrome/browser/push_messaging/push_messaging_service_unittest.cc (right):

https://codereview.chromium.org/2122603007/diff/100001/chrome/browser/push_me...
chrome/browser/push_messaging/push_messaging_service_unittest.cc:98: &profile_,
&BuildFakeGCMProfileService);
nit: remove lines 78-81, use gcm::FakeGCMProfileService::Build here

https://codereview.chromium.org/2122603007/diff/100001/components/gcm_driver/...
File components/gcm_driver/fake_gcm_profile_service.h (right):

https://codereview.chromium.org/2122603007/diff/100001/components/gcm_driver/...
components/gcm_driver/fake_gcm_profile_service.h:5: #ifndef
COMPONENTS_GCM_DRIVER_GCM_FAKE_PROFILE_SERVICE_H_
nit: COMPONENTS_GCM_DRIVER_FAKE_GCM_PROFILE_SERVICE_H_

[kbalazs, 2016-07-14 23:14:47]

https://codereview.chromium.org/2122603007/diff/120001/chrome/browser/extensi...
File chrome/browser/extensions/api/instance_id/instance_id_apitest.cc (left):

https://codereview.chromium.org/2122603007/diff/120001/chrome/browser/extensi...
chrome/browser/extensions/api/instance_id/instance_id_apitest.cc:32:
service->SetDriverForTesting(new instance_id::FakeGCMDriverForInstanceID());
FYI, this is why the tests failed. This Build* variant has to stay because it is
using a different gcm driver.

[Peter Beverloo, 2016-07-15 13:44:10]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 13:44:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2016-07-15 13:58:45]

lgtm if the bots are happy :) Thank you!

https://codereview.chromium.org/2122603007/diff/140001/chrome/browser/push_me...
File chrome/browser/push_messaging/push_messaging_service_unittest.cc (right):

https://codereview.chromium.org/2122603007/diff/140001/chrome/browser/push_me...
chrome/browser/push_messaging/push_messaging_service_unittest.cc:98: &profile_,
&BuildFakeGCMProfileService);
Could this refer to gcm::FakeGCMProfileService::Build?

[commit-bot: I haz the power, 2016-07-15 14:58:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 14:58:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kbalazs, 2016-07-15 17:04:33]

https://codereview.chromium.org/2122603007/diff/140001/chrome/browser/push_me...
File chrome/browser/push_messaging/push_messaging_service_unittest.cc (right):

https://codereview.chromium.org/2122603007/diff/140001/chrome/browser/push_me...
chrome/browser/push_messaging/push_messaging_service_unittest.cc:98: &profile_,
&BuildFakeGCMProfileService);
On 2016/07/15 13:58:45, Peter Beverloo wrote:
> Could this refer to gcm::FakeGCMProfileService::Build?

Done.

[kbalazs, 2016-07-15 17:04:34]

last touchup

[kbalazs, 2016-07-15 17:06:15]

The CQ bit was checked by b.kelemen@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 17:06:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 19:13:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 19:13:18]

Dry run: This issue passed the CQ dry run.

[kbalazs, 2016-08-09 22:21:20]

Oops, I forgot to commit this. Doesn't conflict so I'm going to try it now.

[kbalazs, 2016-08-09 22:24:09]

The CQ bit was checked by b.kelemen@samsung.com

[kbalazs, 2016-08-09 22:24:10]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2122603007/#ps180001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-09 22:24:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 22:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 22:33:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kbalazs, 2016-08-10 15:33:50]

On 2016/08/09 22:33:06, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

@jam, would you please rubber-stamp the files under chrome/browser ?

[Dmitry Titov, 2016-08-11 03:45:02]

I don't need to look at it, Peter and Jam are all you need really.
But lgtm.