Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2121083005: SELECT: Store the suggested value by an HTMLOptionElement pointer instead of an index number. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT: Store the suggested value by an HTMLOptionElement pointer instead of an index number. Managing an OPTION by an index number is a bad idea in general because an index number is fragile. This CL changes m_suggestedIndex from |int| to |Member<HTMLOptionElement>|, and fix a bug about OPTION addition and removal. Committed: https://crrev.com/cf0c390214da2eeaa9407597793fb8f2ff2fda56 Cr-Commit-Position: refs/heads/master@{#403860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -38 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggested-value.html View 4 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/suggested-value-expected.txt View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 7 chunks +15 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tkent
Keishi, would you review this please?
4 years, 5 months ago (2016-07-06 04:58:04 UTC) #3
keishi
LGTM
4 years, 5 months ago (2016-07-06 05:53:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121083005/20001
4 years, 5 months ago (2016-07-06 05:59:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-06 07:12:08 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 07:13:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf0c390214da2eeaa9407597793fb8f2ff2fda56
Cr-Commit-Position: refs/heads/master@{#403860}

Powered by Google App Engine
This is Rietveld 408576698