third_party/WebKit/Source/core/html/HTMLSelectElement.h - Issue 2121083005: SELECT: Store the suggested value by an HTMLOptionElement pointer instead of an index number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2121083005: SELECT: Store the suggested value by an HTMLOptionElement pointer instead of an index number. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/suggested-value-expected.txt ('k') | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.h b/third_party/WebKit/Source/core/html/HTMLSelectElement.h

index 712e1f93e294487c2797942eebf58de2e38268b9..cdc4fe9a9b0a5d5e6fc00a471a4ffcb639bdd1fb 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.h

@@ -54,8 +54,6 @@ public:

int selectedIndex() const;

void setSelectedIndex(int);

- int suggestedIndex() const;

- void setSuggestedIndex(int);

void optionSelectedByUser(int index, bool dispatchChangeEvent, bool allowMultipleSelection = false);

@@ -237,6 +235,7 @@ private:

size_t searchOptionsForValue(const String&, size_t listIndexStart, size_t listIndexEnd) const;

void updateListBoxSelection(bool deselectOtherOptions, bool scroll = true);

void setIndexToSelectOnCancel(int listIndex);

+ void setSuggestedOption(HTMLOptionElement*);

enum SkipDirection {

SkipBackwards = -1,

@@ -274,10 +273,10 @@ private:

Member<HTMLOptionElement> m_activeSelectionAnchor;

Member<HTMLOptionElement> m_activeSelectionEnd;

Member<HTMLOptionElement> m_optionToScrollTo;

+ Member<HTMLOptionElement> m_suggestedOption;

bool m_multiple;

bool m_activeSelectionState;

mutable bool m_shouldRecalcListItems;

- int m_suggestedIndex;

bool m_isAutofilledByPreview;

class PopupUpdater;