Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212103004: [DevTools] Show device screen size in DIPs. (Closed)

Created:
6 years, 9 months ago by dgozman
Modified:
6 years, 8 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[DevTools] Show device screen size in DIPs. BUG=327641 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170587

Patch Set 1 #

Total comments: 2

Patch Set 2 : Migrating settings #

Patch Set 3 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -35 lines) Patch
M LayoutTests/inspector/device-emulation/device-emulation-test.js View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/OverridesSupport.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/OverridesView.js View 1 3 chunks +30 lines, -30 lines 0 comments Download
M Source/devtools/front_end/Settings.js View 1 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
dgozman
Take a look please.
6 years, 9 months ago (2014-03-26 12:32:24 UTC) #1
pfeldman
https://codereview.chromium.org/212103004/diff/1/Source/devtools/front_end/OverridesView.js File Source/devtools/front_end/OverridesView.js (right): https://codereview.chromium.org/212103004/diff/1/Source/devtools/front_end/OverridesView.js#newcode383 Source/devtools/front_end/OverridesView.js:383: "966x604x1.325"], What about settings stored on the user side?
6 years, 9 months ago (2014-03-28 09:42:19 UTC) #2
dgozman
PTAL https://codereview.chromium.org/212103004/diff/1/Source/devtools/front_end/OverridesView.js File Source/devtools/front_end/OverridesView.js (right): https://codereview.chromium.org/212103004/diff/1/Source/devtools/front_end/OverridesView.js#newcode383 Source/devtools/front_end/OverridesView.js:383: "966x604x1.325"], On 2014/03/28 09:42:20, pfeldman wrote: > What ...
6 years, 9 months ago (2014-03-28 12:44:02 UTC) #3
pfeldman
lgtm
6 years, 9 months ago (2014-03-28 13:59:36 UTC) #4
pfeldman
lgtm lgtm
6 years, 9 months ago (2014-03-28 13:59:37 UTC) #5
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 8 months ago (2014-04-01 15:19:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/212103004/40001
6 years, 8 months ago (2014-04-01 15:20:01 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 15:49:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-01 15:49:12 UTC) #9
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 8 months ago (2014-04-01 16:46:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/212103004/60001
6 years, 8 months ago (2014-04-01 16:47:03 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 17:55:57 UTC) #12
Message was sent while issue was closed. 
Change committed as 170587

Powered by Google App Engine
This is Rietveld 408576698